Changes between Version 33 and Version 34 of Hacking

Timestamp:

11/03/24 09:10:44 (3 weeks ago)

Author:

zaytsev

Comment:

--

Hacking

@@ -267 +267 @@
 Reduce variable scope as much as possible: declare local variable in that block where it is used.
 
-Don't mix variable declaration and code, declare variable only in the beginning of block.
-
-Split variable declaration and code using one empty line.
-
-Avoid using function to initialize variable.
-
-Split variable declaration and value assignment.
-
-'''This is right:'''
+If variable is introduced to store intermediate value, declare it as constant.
+
+'''This is right:'''
+{{{
+const vfs_path_t *vpath = vfs_path_from_str (filename);
+}}}
+
+'''This is wrong:'''
 {{{
 vfs_path_t *vpath;
 
 vpath = vfs_path_from_str (filename);
-}}}
-
-'''This is wrong:'''
-{{{
-vfs_path_t *vpath = vfs_path_from_str (filename);
 }}}
 
@@ -324 +318 @@
     WPanel *panel = current_panel;
     int i;
-    ComputeDirSizeUI *ui;
-
-    ui = compute_dir_size_create_ui ();
+    
+    const ComputeDirSizeUI *ui = compute_dir_size_create_ui ();
 
     compute_dir_size_destroy_ui (ui);
@@ -340 +333 @@
 {
     compute_dir_size_destroy_ui (compute_dir_size_create_ui ());
+}
+}}}
+
+Avoid abusing non-const function parameters as local variables:
+
+'''This is right:'''
+{{{
+void
+foo (const int iterations)
+{
+    int result;
+
+    do_one_thing (iterations);
+    do_something (result);
+    ...
+}
+}}}
+
+'''This is wrong:'''
+{{{
+void
+foo (int iterations)
+{
+    do_one_thing (iterations);
+    do_something (iterations);
+    ...
 }
 }}}