Changes between Version 9 and Version 10 of Hacking

Timestamp:

02/15/11 21:20:39 (14 years ago)

Author:

angel_il

Comment:

--

Hacking

@@ -71 +71 @@
 }}}
 
-=== Code blocks (if, for, case...)===
+=== Code blocks (if, for, case...) ===
 
 Always follow an 'if' keyword with a space but don't include additional
 spaces following or preceding the parentheses in the conditional.
 
-This is right:
+'''This is right:'''
 {{{
     if (i == 0)
 }}}
-This is wrong:
+'''This is wrong:'''
 {{{
     if ( i == 0 )
-    /* 
     if (0 == i)
 }}}
@@ -89 +88 @@
 Always insert a space between the name and left parentheses when invoking functions.
 
-This is right:
+'''This is right:'''
 {{{
     do_example (int param1, int *result1);
 }}}
-This is wrong:
+'''This is wrong:'''
 {{{
     do_example(int param1, int *result1);
 }}}
-
-
 
 Braces for code blocks used by '''for, if, switch, while, do..while''', etc. should begin on the next line after the statement keyword and end on a line of their own. 
@@ -106 +103 @@
 If the beginning statement has to be broken across lines due to length, the beginning brace should be on a line of its own.
 
-This is right:
+'''This is right:'''
 {{{
     if (xterm_flag && xterm_title)
@@ -121 +118 @@
 
 }}}
-This is wrong:
+'''This is wrong:'''
 {{{
     if (xterm_flag && xterm_title) {
@@ -137 +134 @@
                 g_free (*str_options[i].opt_addr);
 
+}}}
+
+Use "goto" only when necessary. "goto"s are evil, but they can greatly enhance readability and reduce memory leaks when used as the single exit point from a function. 
+
+'''This is right:'''
+{{{
+{
+    if (link_type == LINK_HARDLINK)
+    {
+        src = g_strdup_printf (_("Link %s to:"), str_trunc (fname, 46));
+        dest = input_expand_dialog (_("Link"), src, MC_HISTORY_FM_LINK, "");
+
+        if (!dest || !*dest)
+            goto cleanup;
+    ...
+    ...
+    }
+  ...
+  ...
+
+  cleanup:
+    g_free (src);
+    g_free (dest);
+}
 }}}