Ticket #96 (closed defect: fixed)

Opened 11 years ago

Last modified 10 years ago

segfault-on-invalid-mtime fix

Reported by: slavazanko Owned by: metux
Priority: critical Milestone: 4.6.2
Component: mc-core Version:
Keywords: committed-master committed-mc-4.6 vote-winnie vote-slavazanko Cc: weigelt@…
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

Invalid timestamps on files caused mc to segfault by passing a null
pointer to strftime. Avoid trying to print the time in this case.

Source: Gentoo Portage
Reference: mc-4.6.1
Reported-By: Maxim Britov <maxim office modum by>
Reported-Bug: http://bugs.gentoo.org/184296
Submit-By: Enrico Weigelt, metux IT service <weigelt metux de>
Submit-Date: 2008-12-26
State: new

See attachment.

Attachments

segfault-on-invalid-mtime.patch (1.1 KB) - added by slavazanko 11 years ago.
mc-4.6.1-ac-fix-obsolete-ac_aix.diff (586 bytes) - added by metux 11 years ago.
A more deep fix …
mc-4.6.1-timefmt.diff (4.8 KB) - added by metux 11 years ago.
Now the right one: reworked time formatting
fix-timefmt-rev2.patch (4.5 KB) - added by winnie 11 years ago.
Patch rediffed to apply on latest git. (Also created a 96_segfault_invalid_mtime branch with this patch applied inside)

Change History

Changed 11 years ago by slavazanko

comment:1 Changed 11 years ago by metux

  • Cc weigelt@… added
  • Priority changed from major to critical
  • Milestone set to Bug Fixing

Quite critical, should really go into next release.

Changed 11 years ago by metux

A more deep fix ...

comment:2 Changed 11 years ago by winnie

  • Milestone changed from Bug Fixing to 4.6.2

Reassign to 4.6.2 as this should be the bugfix release.

comment:3 Changed 11 years ago by slavazanko

hm.. is patch mc-4.6.1-ac-fix-obsolete-ac_aix.diff really helps with fix this trouble? Or patch is a wrong?

comment:4 Changed 11 years ago by metux

Ups, obviously I uploaded the wrong patch ;-o

Changed 11 years ago by metux

Now the right one: reworked time formatting

comment:5 Changed 11 years ago by metux

  • Keywords review added

comment:6 Changed 11 years ago by winnie

  • Owner set to metux
  • Status changed from new to assigned
  • Keywords vote-winnie added

Assign metux as owner as until now nobody owns this bug really.
@metux: Please set the bug to accepted.

btw. I'll add a rev2 of the patch as this own doesn't apply on latest git (mc-4.6 branch).

Changed 11 years ago by winnie

Patch rediffed to apply on latest git. (Also created a 96_segfault_invalid_mtime branch with this patch applied inside)

comment:7 Changed 11 years ago by metux

  • Status changed from assigned to accepted

comment:8 Changed 11 years ago by slavazanko

  • Keywords vote-slavazanko added

comment:9 Changed 11 years ago by slavazanko

  • Keywords approved added

comment:10 Changed 11 years ago by metux

  • Keywords committed-master committed-mc-4.6 added; review approved removed

comment:11 Changed 11 years ago by winnie

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:12 Changed 11 years ago by winnie

  • Status changed from testing to closed

comment:13 Changed 11 years ago by slavazanko

deleted 96_segfault_invalid_mtime branch from parent git.

Note: See TracTickets for help on using tickets.