Ticket #89 (closed defect: fixed)

Opened 11 years ago

Last modified 6 years ago

savannah: mc shows wrong metadata for ".." directory

Reported by: darkk Owned by: andrew_b
Priority: major Milestone: 4.7
Component: mc-core Version: 4.6.2
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: commited-master

Description (last modified by ossi) (diff)

Original: http://savannah.gnu.org/bugs/?24808

Submitted by:Leonid Evdokimov <darkk>Submitted on:Tue 11 Nov 2008 08:22:32 AM UTC
Category:Screen outputSeverity:3 - Normal
Status:NonePrivacy:Public
Assigned to:NoneOpen/Closed:Open
Release:4.6.1Operating System:GNU/Linux

Original submission:

mc always shows 0755 as ".." permissions ­— that's incorrect 
behaviour.
Much better way is to show nothing as mc does not show mtime, size 
and some other attributes of ".." at all.

User, group and some other values are broken too, seems, 
src/screen.c should be patched to check for ".." in more places. 

Change History

comment:1 Changed 10 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Version set to 4.6.2
  • Keywords review added
  • Milestone set to 4.7

89_parent_dir_metadata is created; parent branch: master.

Solution: display "UP--DIR" in mini-status when ".." is selected.

comment:2 follow-up: ↓ 3 Changed 10 years ago by slavazanko

  • Keywords vote-slavazanko added

IMHO good solution. Patch contain comment:

FIXME:
while loading directory (do_load_dir() and do_reload_dir(),
the actual stat info about ".." directory isn't got;
so just don't display incorrect info about ".." directory

I think, not needed to retrieve stat info for '..' directory. What think others?

comment:3 in reply to: ↑ 2 Changed 10 years ago by styx

  • Keywords vote-styx approved added; review removed

Replying to slavazanko:

IMHO good solution. Patch contain comment:

FIXME:
while loading directory (do_load_dir() and do_reload_dir(),
the actual stat info about ".." directory isn't got;
so just don't display incorrect info about ".." directory

I think, not needed to retrieve stat info for '..' directory. What think others?

I am agree with you, there is no need to get stat info for '..' directory.

comment:4 Changed 10 years ago by andrew_b

  • Status changed from accepted to testing
  • Keywords commited-master added; vote-slavazanko vote-styx approved removed
  • Resolution set to fixed

comment:5 Changed 10 years ago by styx

  • Status changed from testing to closed

comment:6 Changed 6 years ago by ossi

  • Description modified (diff)
  • Branch state set to no branch
  • Reporter changed from slavazanko to darkk

comment:7 Changed 6 years ago by andrew_b

  • Keywords commited-master removed
  • Votes for changeset set to commited-master
  • Branch state changed from no branch to merged
Note: See TracTickets for help on using tickets.