Ticket #84 (closed defect: fixed)

Opened 10 years ago

Last modified 5 years ago

savannah: File names not correctly handled in iso9660 vfs

Reported by: cppgx Owned by: guanx
Priority: major Milestone: 4.7.0-pre1
Component: mc-vfs Version: 4.6.2-pre1
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-mc-4.6

Description (last modified by ossi) (diff)

Original: http://savannah.gnu.org/bugs/?23753

Submitted by:Guan Xin <cppgx>Submitted on:Fri 04 Jul 2008 03:27:46 AM UTC
Category:VFSSeverity:3 - Normal
Status:NonePrivacy:Public
Assigned to:NoneOpen/Closed:Open
Release:4.6.1Operating System:All

Original submission:

Because filenames are not properly processed, mc does not work with isoinfo.

GNU Midnight Commander 2007-03-09-18
isoinfo 2.01.01a18

1. Got wrong file names. Then no file could be copied out.
2. Does not handle symlinks in .iso files.

Please apply the attached patch. 

branch:84_iso9660
changeset:d6a6f40ad2d359ec05363656cf05bc5f84ce1c52

Attachments

iso9660.in.diff (374 bytes) - added by slavazanko 10 years ago.
added by cppgx
vfstest.iso.gz (12.6 KB) - added by guanx 10 years ago.
sample iso image
iso9660original.png (8.1 KB) - added by guanx 10 years ago.
display without patch
iso9660patched.png (7.8 KB) - added by guanx 10 years ago.
display with patch

Change History

Changed 10 years ago by slavazanko

added by cppgx

comment:1 Changed 10 years ago by guanx

  • Status changed from new to accepted
  • Owner set to guanx

comment:2 Changed 10 years ago by guanx

  • Component changed from mc-core to vfs

comment:3 Changed 10 years ago by guanx

  • Keywords iso9660 isoinfo awk regular expression added
  • Version set to 4.6.2~pre1
  • Milestone set to 4.6.2

comment:4 Changed 10 years ago by guanx

  • Blocked By 217 added

comment:5 Changed 10 years ago by guanx

  • Blocking 217 added
  • Blocked By 217 removed

comment:6 Changed 10 years ago by winnie

  • Blocking 217 removed

(In #217) This bug surely belongs into the bugfix 4.6.X but as the buglist for 4.6.2 is already freezed this will be fixed in 4.6.3.

I'll add a review keyword to this patch so we can review it, if this patch is approved before the 4.6.2 release this will be part of the release, but it won't be a blocker.

comment:7 follow-up: ↓ 8 Changed 10 years ago by winnie

  • Keywords review added; iso9660 isoinfo awk regular expression removed
  • Milestone changed from 4.6.2 to 4.6.3

This bug surely belongs into the bugfix 4.6.X but as the buglist for 4.6.2 is already freezed this will be fixed in 4.6.3.

I'll add a review keyword to this patch so we can review it, if this patch is approved before the 4.6.2 release this will be part of the release, but it won't be a blocker.

comment:8 in reply to: ↑ 7 ; follow-up: ↓ 9 Changed 10 years ago by guanx

Replying to winnie:

This bug surely belongs into the bugfix 4.6.X but as the buglist for 4.6.2 is already freezed this will be fixed in 4.6.3.

I'll add a review keyword to this patch so we can review it, if this patch is approved before the 4.6.2 release this will be part of the release, but it won't be a blocker.

Sorry, I'm not familiar with this system. I've created a useless ticket (#217) which is duplicate. I'll be more careful in the future.

comment:9 in reply to: ↑ 8 Changed 10 years ago by winnie

Replying to guanx:

Replying to winnie:

This bug surely belongs into the bugfix 4.6.X but as the buglist for 4.6.2 is already freezed this will be fixed in 4.6.3.

I'll add a review keyword to this patch so we can review it, if this patch is approved before the 4.6.2 release this will be part of the release, but it won't be a blocker.

Sorry, I'm not familiar with this system. I've created a useless ticket (#217) which is duplicate. I'll be more careful in the future.

No problem, you don't have to be sorry for that. It's nice to see new people commiting patches. If you like feel free to review also patches and add your thoughts about them to the appropiate ticket.

comment:10 Changed 10 years ago by metux

  • Keywords vote-metux added
  • Description modified (diff)

Changed 10 years ago by guanx

sample iso image

Changed 10 years ago by guanx

display without patch

Changed 10 years ago by guanx

display with patch

comment:11 Changed 10 years ago by slyfox

  • Keywords vote-slyfox approved committed-mc-4.6 committed-master added; review removed
  • Status changed from accepted to testing
  • Resolution set to fixed

comment:12 Changed 10 years ago by styx

  • Status changed from testing to closed

comment:13 Changed 10 years ago by anonymous

  • Milestone 4.6.2.1 deleted

Milestone 4.6.2.1 deleted

comment:14 Changed 9 years ago by andrew_b

  • Keywords vote-metux vote-slyfox approved removed
  • severity set to merged
  • Milestone set to 4.7.0-pre1

comment:15 Changed 5 years ago by ossi

  • Description modified (diff)
  • Branch state set to no branch
  • Reporter changed from slavazanko to cppgx

comment:16 Changed 5 years ago by andrew_b

  • Keywords committed-mc-4.6 committed-master removed
  • Votes for changeset set to committed-master committed-mc-4.6
  • Branch state changed from no branch to merged
Note: See TracTickets for help on using tickets.