savannah: "preserve Attributes" unchecked, but chmod errors still there

[bilboq]

Original: ​http://savannah.gnu.org/bugs/?21030

Submitted by:	Martin Petricek <bilboq>	Submitted on:	Tue 11 Sep 2007 09:38:08 AM UTC
Category:	Core	Severity:	3 - Normal
Status:	In Progress	Privacy:	Public
Assigned to:	Pavel Tsekov <ptsekov>	Open/Closed:	Open
Release:	current (CVS or snapshot)	Operating System:	GNU/Linux

Original submission:

I have tried copying files from mounted FAT filesystem (memory card)
 to a NTFS filesystem (which was mounted using ntfs-3g over FUSE). I
unchecked "preserve Attributes" (as NTFS does not support 
chown/chmod)

But even with the preserve attributes unchecked I got following 
error message:

Cannot chmod target file "/m/s/eg/100_4646.jpg"
Operation not permitted (1)

on each of the files. I hoped to avoid this when I unchecked 
"preserve Attributes".

I am using CVS version of MC, checked out and recompiled just few 
minutes ago, running on debian unstable, amd64 architecture.

Comment 1 by Pavel Tsekov <ptsekov> at Thu 13 Sep 2007 09:35:30 AM UTC:

This problem has been discussed already in that thread:

http://mail.gnome.org/archives/mc-devel/2007-January/msg00075.html

I'll reread the thread and see whether to apply the suggested 
solution/workaround.

Comment 2 by Pavel Tsekov <ptsekov> at Thu 13 Sep 2007 12:49:30 PM UTC:

Please, test the attached patch.

(file #13935)

Comment 3 by Martin Petricek <bilboq> at Thu 13 Sep 2007 02:34:33 PM UTC:

Tried attached patch (file #13935) and it works for me. No more 
chmod complaints when "preserve attributes" unchecked when copying 
from FAT32 to NTFS partition. I have not observerd any ill effects 
from the patch.

Comment 4 by Pavel Tsekov <ptsekov> at Mon 17 Sep 2007 07:03:46 PM UTC:

I just have to think how to handle the EEXIST case from the patch 
and I'll commit it in CVS - hopefully it will get in 4.6.2. I'll 
appreciate it of anyone could help me with that and especially with 
the wording of the error message to be displayed to the user.

branch:72_preserve_attributes
changeset:5097e9b62ed28ada175a4cfc27eee3f823d7345b

[slavazanko]

added by ptsekov

[guanx]

This patch fixed two problems:

1. When copying files, between mc's checking the target's non-existence and open(2)-ing the target file, (sym)link attack is possible.
2. Even when "Preserve Attributes" is unchecked, permissions are still preserved.

[angel_il]

this patch still actual? i think no.

[slavazanko]

Patch actual.

Now rebased to master.

Also, added automatic toggle 'Preserve attributes' checkbox (relative to type of target filesystem)

Review & vote, please.

[iNode]

When checkbox 'Preserve attributes' unchecked file permissions also saved.
How to repeat:

touch test
umask 022
chmod 0600 test
F5 (without Preserve attributes checked)
ls -l %D/test

[angel_il]

branch: 72_preserve_attributes (parent: master)

[slavazanko]

rebased to current master.

changeset:f856eeb0eac182c2d7e9896b40c5a2fea46d5574
changeset:ce129506f6841e85da2389b18fdb49d0826a3021

[iNode]

It's still doesn't work as described in case 2.

Please rework.

[slavazanko]

It's still doesn't work as described in case 2

changeset:f37120e8fc69a8e307f44b65e8f940f32f5b23a8

review

[iNode]

Now it work correct. Thanks.

[slavazanko]

Merge commit: 78f01a3a9ae7ef8b91c7541edd4760ac5a0d3f8f