Changes between Initial Version and Version 2 of Ticket #70


Ignore:
Timestamp:
01/11/14 17:10:14 (6 years ago)
Author:
ossi
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #70

    • Property Reporter changed from slavazanko to me4mc
    • Property Branch state changed from to no branch
    • Property Milestone changed from to future releases
  • Ticket #70 – Description

    initial v2  
    77||Release:||4.6.1||Operating System:||GNU/Linux|| 
    88 
    9 Discussion: 
     9Original submission: 
    1010{{{ 
    11 Sat 06 Oct 2007 09:03:19 AM UTC, comment #4: 
     11action: press ctrl+pgdown to enter a archive (vfs) 
     12result: nothing happens 
     13expect: enter archive 
    1214 
     15fix: press enter 
     16 
     17problem: commandline must be empty 
     18fix: add 
     19regex_command (selection (panel)->fname, "Open", 0) 
     20to 
     21ctrl_next_page handler 
     22 
     23hope this shortens the todolist 
     24}}} 
     25 
     26Comment 1 by Pavel Tsekov <ptsekov> at Thu 23 Aug 2007 02:58:10 PM UTC: 
     27{{{ 
     28Using regex_command(..., "Open", ...) doesn't always translate to 
     29"cd path#vfs" - it may end up executing external commands. I am not  
     30sure whether this behaviour is desired for Ctrl + PgDn... 
     31}}} 
     32 
     33Comment 2 by me <me4mc> at Thu 23 Aug 2007 04:01:16 PM UTC: 
     34{{{ 
     35afairemember the regex_command is what pressing return does. i just  
     36added it for the existing key binding - didnt really think that far :(. 
     37 
     38imo crtl+pgdn/pgup should only cd, never execute. 
     39 
     40is changing 'do_cd' the more clean approach? 
     41}}} 
     42 
     43Comment 3 by Pavel Tsekov <ptsekov> at Fri 24 Aug 2007 02:34:08 PM UTC: 
     44{{{ 
     45do_cd() needs a vfs path to enter into archives or connect to ftp or 
     46 ssh servers. So, if you press Ctrl+PgDn on a, say, .zip file, you  
     47need to: 
     48 
     49a) determine the file type (as regex_open() does) 
     50b) translate the path to vfs path 
     51c) pass the vfs path to do_cd() 
     52 
     53Maybe regex_open() can be modified so that it will recognize a new  
     54action which will make it return the vfs path for a given path ... or something like that. 
     55}}} 
     56 
     57Comment 4 by me <me4mc> at Sat 06 Oct 2007 09:03:19 AM UTC: 
     58{{{ 
    1359i finaly managed to read the code: 
    1460a) 
     
    3480main.c:606,1028 
    3581ext.c:416,594 
    36         me <me4mc> 
    37 Fri 24 Aug 2007 02:34:08 PM UTC, comment #3: 
    38  
    39 do_cd() needs a vfs path to enter into archives or connect to ftp or 
    40  ssh servers. So, if you press Ctrl+PgDn on a, say, .zip file, you  
    41 need to: 
    42  
    43 a) determine the file type (as regex_open() does) 
    44 b) translate the path to vfs path 
    45 c) pass the vfs path to do_cd() 
    46  
    47 Maybe regex_open() can be modified so that it will recognize a new  
    48 action which will make it return the vfs path for a given path ... or something like that. 
    49         Pavel Tsekov <ptsekov> 
    50 Project Administrator 
    51 Thu 23 Aug 2007 04:01:16 PM UTC, comment #2: 
    52  
    53 afairemember the regex_command is what pressing return does. i just  
    54 added it for the existing key binding - didnt really think that far :(. 
    55  
    56 imo crtl+pgdn/pgup should only cd, never execute. 
    57  
    58 is changing 'do_cd' the more clean approach? 
    59         me <me4mc> 
    60 Thu 23 Aug 2007 02:58:10 PM UTC, comment #1: 
    61  
    62 Using regex_command(..., "Open", ...) doesn't always translate to 
    63 "cd path#vfs" - it may end up executing external commands. I am not  
    64 sure whether this behaviour is desired for Ctrl + PgDn... 
    65         Pavel Tsekov <ptsekov> 
    66 Project Administrator 
    67 Sat 16 Jun 2007 07:36:43 AM UTC, original submission: 
    68  
    69 action: press ctrl+pgdown to enter a archive (vfs) 
    70 result: nothing happens 
    71 expect: enter archive 
    72  
    73 fix: press enter 
    74  
    75 problem: commandline must be empty 
    76 fix: add 
    77 regex_command (selection (panel)->fname, "Open", 0) 
    78 to 
    79 ctrl_next_page handler 
    80  
    81 hope this shortens the todolist 
    8282}}}