savannah: Aborting a FISH file transfer is grossly inefficient

[ptsekov]

Original: ​http://savannah.gnu.org/bugs/?19721

Submitted by:	Pavel Tsekov <ptsekov>	Submitted on:	Fri 27 Apr 2007 08:40:45 AM UTC
Category:	VFS	Severity:	3 - Normal
Status:	None	Privacy:	Public
Assigned to:	None	Open/Closed:	Open
Release:	All versions	Operating System:	All

Original submission:

I was looking at the fish code recently and noticed that aborting
a running file transfer still causes MC to read the whole file sent 
by the remote end. I realized that the way FISH is currently
implemented, i.e. commands and data sent over the same channel, this
 is the only way to clear the data channel so that command replies 
would get to the FISH layer without re-establishing a new link. 
While this could be acceptable for small transfers I doubt it that 
it makes sens for multi-megabyte files.

Ideas on how to fix it are welcome. One way I can see is to
open a separate FISH connection for the data transfer i.e. like FTP. 

Comment 1 by Oswald Buddenhagen <ossi> at Fri 27 Apr 2007 12:20:17 PM UTC:

no, i think we can do like ssh does, i.e., tunnel multiple virtual 
connections through one physical connection. this adds some 
overhead, though (especially cpu-wise, as we have to call dd for 
every chunk).

btw, you might want to look at kde's fishserv.pl, it has some 
optimizations. never looked at it myself, though.

Comment 2 by Pavel Tsekov <ptsekov> at Fri 27 Apr 2007 01:38:47 PM UTC:

Sounds interesting - I'll take a look at it. My perl is pretty bad 
though - I hope the code is not too complicated.

Comment 3 by Pavel Tsekov <ptsekov> at Wed 02 May 2007 01:20:28 PM UTC:

Unfortunately kde's fish implementation (as found in kioslave/fish 
directory) is not a improvement in this particular case. At least I 
do not see any code which deals with aborting a file transfer 
gracefully. Most likely the connection is just killed.

Comment 4 by Pavel Tsekov <ptsekov> at Mon 07 May 2007 01:06:26 PM UTC:

I've tested the ssh ability to tunnel multiple session over the same
 connection and it works nicely. There is one problem though - it is
 supported only with SSH protocol v2.

Comment 5 by Oswald Buddenhagen <ossi> at Mon 07 May 2007 04:18:32 PM UTC:

huh? you actually used ssh for that? i guess that's a fine optimization.
but for the general case the chunking should be homegrown (based on 
dd and printf/read, i guess).

[metux]

Is this still valid with the new fish implementation ?

[zaytsev]

Sure it is.

P.S. SSH2+ sounds like a reasonable requirement nowadays.

[angel_il]

branch: 68_fish_abort_file_transfer_fix (parent master)
changeset: ​68_fish_abort_file_transfer_fix

[angel_il]

please review

[slavazanko]

Need rebase to current 'master' branch

[angel_il]

forced update: 68_fish_abort_file_transfer_fix

[angel_il]

please review

[slavazanko]

In my point of view, need to resolve #77 issue first, then probably this ticket will be non-actual. If not - we will continue development from this point.