Ticket #54 (closed defect: fixed)

Opened 10 years ago

Last modified 5 years ago

savannah: Config checkboxes not acting on mouse click

Reported by: egmont Owned by: andrew_b
Priority: major Milestone: 4.7.0-pre4
Component: mc-core Version: 4.6.1
Keywords: groupbox Cc: egmont@…
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description (last modified by ossi) (diff)

Original: http://savannah.gnu.org/bugs/?18689

Submitted by:Egmont Koblinger <egmont>Submitted on:Thu 04 Jan 2007 06:52:40 PM UTC
Category:NoneSeverity:3 - Normal
Status:ConfirmedPrivacy:Public
Assigned to:NoneOpen/Closed:Open
Release:current (CVS or snapshot)Operating System:GNU/Linux

Original submission:

Under Options/Configuration and Options/Layout, checkbox or 
radiobutton options that precede the currently focused widget are 
not clickable with mouse, these mouse clicks are simply ignored.

Example: open the Options/Configuration dialog, click on the 
checkbox of the last option ("safe deLete"), then click on any 
other option with your mouse, this second click will have no 
effect. You have to use the keyboard or close this dialog and open 
again to change these options.

Tested with 4.6.1 and with 2007-01-04-16 snapshot, both on Linux 
console (gpm) and in gnome-terminal. 

Comment 1 by Pavel Tsekov <ptsekov> at Fri 05 Jan 2007 01:40:25 PM UTC:

Oh, well. The mouse event is directed to the groupbox (the frame 
holding other widgets inside it). The bad thing is that the 
groupbox is rather simplistic widget and it doesn't know anything 
about the widgets that are displayed inside it :( IMO, the real 
solution to this problem should involve teaching the groupbox that 
it holds other widgets (i.e. making it a real container widget). A 
simplistic solution would be to skip groupboxes when dispatching 
mouse events.

Attachments

dlg_mouse_event-skip-widget-w-o-action.patch (474 bytes) - added by sfionov 9 years ago.

Change History

comment:1 Changed 10 years ago by styx

  • Milestone set to future releases

comment:2 Changed 10 years ago by angel_il

  • severity set to no branch
  • Milestone changed from future releases to 4.7.0-pre3

comment:3 Changed 10 years ago by angel_il

  • Milestone changed from 4.7.0-pre3 to 4.7.0-pre5

comment:4 Changed 9 years ago by sfionov

The trivial fix is to skip widgets that matches coords but does not have an action (usually groupboxes), continuing search of widget with defined action.

Changed 9 years ago by sfionov

comment:5 Changed 9 years ago by slavazanko

  • Owner set to andrew_b
  • Status changed from new to assigned

comment:6 Changed 9 years ago by andrew_b

  • severity changed from no branch to on review
  • Milestone changed from 4.7.0-pre5 to 4.7.0-pre4

Created 54_dlg_mouse_handling branch. Parent branch: master.
changeset:85211c5748d85458ffa02812a7ca001a4a3096c8

comment:7 Changed 9 years ago by angel_il

  • Keywords checkbox added
  • Votes for changeset set to angel_il

comment:8 Changed 9 years ago by andrew_b

  • Keywords groupbox added; checkbox removed

comment:9 Changed 9 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

Works. Thanks.

comment:10 Changed 9 years ago by andrew_b

  • Status changed from assigned to testing
  • Votes for changeset changed from angel_il slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:11 Changed 9 years ago by andrew_b

  • Status changed from testing to closed

comment:12 Changed 9 years ago by andrew_b

  • Version set to 4.6.1

comment:13 Changed 5 years ago by ossi

  • Description modified (diff)
  • Branch state set to no branch
  • Reporter changed from slavazanko to egmont

comment:14 Changed 5 years ago by egmont

  • Cc egmont@… added

comment:15 Changed 5 years ago by andrew_b

  • Branch state changed from no branch to merged
Note: See TracTickets for help on using tickets.