Ticket #4605 (closed enhancement: fixed)
Do not override ENV variable for ash/dash subshell
| Reported by: | d3m3t3r | Owned by: | zaytsev |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.8.33 |
| Component: | mc-core | Version: | master |
| Keywords: | subshell ash dash | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
Do not override ENV variable (by ".profile") for ash/dash subshell if it is already set. Currently, mc would fallback to ".profile" file disregarding the existing value of ENV. ENV variable is used to set interactive shell rc-file for ash/dash (or POSIX shells in general). I believe fallback to ENV should be preferred and also consistent with behavior of bash subshell where mc fallbacks ri .bashrc.
Attachments
Change History
comment:1 Changed 3 months ago by d3m3t3r
The patch is attached (also as Github PR https://github.com/MidnightCommander/mc/pull/210)
comment:2 Changed 3 months ago by d3m3t3r
- Priority changed from major to minor
- Keywords subshell ash dash added
comment:4 Changed 3 weeks ago by zaytsev
- Owner set to zaytsev
- Status changed from new to accepted
- Branch state changed from no branch to on review
Branch: 4605_ash_dash_env_init
Initial changeset: 8f9ddb214faa5752b3a07936d638cad82791effc
comment:5 Changed 3 weeks ago by andrew_b
- Votes for changeset set to andrew_b
- Branch state changed from on review to approved
comment:6 Changed 3 weeks ago by zaytsev
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: 9fe4fb85fc35098170d5dea4d8cd9536f0169d78
Thank you d3m3t3r!
Note: See
TracTickets for help on using
tickets.
