Ticket #4597 (new enhancement)
Improve fish 4.0 shell support
| Reported by: | zaytsev | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.8.33 |
| Component: | mc-core | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | no branch | Votes for changeset: |
Description (last modified by zaytsev) (diff)
Attachments
Change History
comment:3 Changed 9 days ago by zaytsev
Yes, I don't like the environment variable thing all... Is it possible for fish to parse our version from mc --version? If this is not practical, maybe we could consider exporting a generic MC_VERSION variable?
comment:4 Changed 7 days ago by johannes
I just sent an updated patch series to the mailing list,
to use MC_VERSION instead.
That third patch is not absolutely necessary but it would be nice, to allow users to converge quicklier on the new keyboard input style.
Let me know if there is anything else for me to do; I realize I didn't add a changelog entry; not sure if that's necessary.
comment:5 Changed 7 days ago by zaytsev
Could you please just attach them here (git format-patch HEAD~~)? I'm not sure if there are any differences otherwise and it's really painful to save messages and upload. I will remove my first comment.
Changed 6 days ago by johannes
- Attachment 0002-Ticket-4597-recognize-CSI-u-encoding-for-ctrl-o.patch added
Changed 6 days ago by johannes
- Attachment 0003-Ticket-4597-export-MC_VERSION-to-subshell.patch added
comment:7 Changed 6 days ago by johannes
Ok done.
Indeed git format-patch is exactly what git send-email sends, so running git am will give the same result.
I wasn't familiar with Trac, maybe the "Reporting problems" section in the README should say that it's preferred to submit patches on Trac.
(I also somehow didn't receive an email notification for comments)
comment:8 Changed 6 days ago by zaytsev
Thank you! I hope we solve the familiarity problem by dropping Trac one day... instead of adding more info to the README. But good point, need to check what it says now. Not very smart if it currently says to send patches to the mailing list, then ask people to post to Trac on the mailing list.
comment:9 Changed 6 days ago by johannes
I personally enjoy using mailing lists but I can see how they are not for everyone. There's an initial barrier to entry that most potential contributors won't cross. Some projects offer multiple avenues for sending patches (for example both Github and a mailing list), I think that's often a good choice
