Context Navigation

Ticket #4593 (closed defect: fixed)

Opened 7 weeks ago

Last modified 5 weeks ago

Midnight Commander Git (Today) possible Regression

Reported by:	Axanar	Owned by:	andrew_b
Priority:	major	Milestone:	4.8.33
Component:	compilation	Version:	master
Keywords:		Cc:
Blocked By:		Blocking:	#4595
Branch state:	merged	Votes for changeset:	committed-master

Description (last modified by zaytsev) (diff)

Hi,

Trying to rebuild Midnight Commander from Git toda on Fedora 41.
I received the following output by simply issuing

./autogen.sh
./configure --prefix=/usr
make

I've seen that there are a few changes made in the past 48hrs. Maybe something got overseen.

It would be nice, if someone could have a look at it.

make[4]: Entering directory '/root/rpmbuild/BUILD/mc-4.8.33-build/mc-4.8.33/src/vfs/tar'
  CC       tar-sparse.lo
tar-sparse.c: In function 'pax_decode_header':
tar-sparse.c:85:29: error: implicit declaration of function '_GL_TYPE_WIDTH' [-Wimplicit-function-declaration]
   85 |     (INT_BITS_STRLEN_BOUND (_GL_TYPE_WIDTH (t) - _GL_SIGNED_TYPE_OR_EXPR (t)) \
      |                             ^~~~~~~~~~~~~~
tar-sparse.c:73:37: note: in definition of macro 'INT_BITS_STRLEN_BOUND'
   73 | #define INT_BITS_STRLEN_BOUND(b) (((b) * 146 + 484) / 485)
      |                                     ^
tar-sparse.c:90:31: note: in expansion of macro 'INT_STRLEN_BOUND'
   90 | #define INT_BUFSIZE_BOUND(t) (INT_STRLEN_BOUND (t) + 1)
      |                               ^~~~~~~~~~~~~~~~
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:557:19: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  557 |         char nbuf[UINTMAX_STRSIZE_BOUND];
      |                   ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:85:29: warning: nested extern declaration of '_GL_TYPE_WIDTH' [-Wnested-externs]
   85 |     (INT_BITS_STRLEN_BOUND (_GL_TYPE_WIDTH (t) - _GL_SIGNED_TYPE_OR_EXPR (t)) \
      |                             ^~~~~~~~~~~~~~
tar-sparse.c:73:37: note: in definition of macro 'INT_BITS_STRLEN_BOUND'
   73 | #define INT_BITS_STRLEN_BOUND(b) (((b) * 146 + 484) / 485)
      |                                     ^
tar-sparse.c:90:31: note: in expansion of macro 'INT_STRLEN_BOUND'
   90 | #define INT_BUFSIZE_BOUND(t) (INT_STRLEN_BOUND (t) + 1)
      |                               ^~~~~~~~~~~~~~~~
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:557:19: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  557 |         char nbuf[UINTMAX_STRSIZE_BOUND];
      |                   ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:92:50: error: expected expression before 'uintmax_t'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                                                  ^~~~~~~~~
tar-sparse.c:73:37: note: in definition of macro 'INT_BITS_STRLEN_BOUND'
   73 | #define INT_BITS_STRLEN_BOUND(b) (((b) * 146 + 484) / 485)
      |                                     ^
tar-sparse.c:90:31: note: in expansion of macro 'INT_STRLEN_BOUND'
   90 | #define INT_BUFSIZE_BOUND(t) (INT_STRLEN_BOUND (t) + 1)
      |                               ^~~~~~~~~~~~~~~~
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:557:19: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  557 |         char nbuf[UINTMAX_STRSIZE_BOUND];
      |                   ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:85:50: error: implicit declaration of function '_GL_SIGNED_TYPE_OR_EXPR' [-Wimplicit-function-declaration]
   85 |     (INT_BITS_STRLEN_BOUND (_GL_TYPE_WIDTH (t) - _GL_SIGNED_TYPE_OR_EXPR (t)) \
      |                                                  ^~~~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:73:37: note: in definition of macro 'INT_BITS_STRLEN_BOUND'
   73 | #define INT_BITS_STRLEN_BOUND(b) (((b) * 146 + 484) / 485)
      |                                     ^
tar-sparse.c:90:31: note: in expansion of macro 'INT_STRLEN_BOUND'
   90 | #define INT_BUFSIZE_BOUND(t) (INT_STRLEN_BOUND (t) + 1)
      |                               ^~~~~~~~~~~~~~~~
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:557:19: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  557 |         char nbuf[UINTMAX_STRSIZE_BOUND];
      |                   ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:85:50: warning: nested extern declaration of '_GL_SIGNED_TYPE_OR_EXPR' [-Wnested-externs]
   85 |     (INT_BITS_STRLEN_BOUND (_GL_TYPE_WIDTH (t) - _GL_SIGNED_TYPE_OR_EXPR (t)) \
      |                                                  ^~~~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:73:37: note: in definition of macro 'INT_BITS_STRLEN_BOUND'
   73 | #define INT_BITS_STRLEN_BOUND(b) (((b) * 146 + 484) / 485)
      |                                     ^
tar-sparse.c:90:31: note: in expansion of macro 'INT_STRLEN_BOUND'
   90 | #define INT_BUFSIZE_BOUND(t) (INT_STRLEN_BOUND (t) + 1)
      |                               ^~~~~~~~~~~~~~~~
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:557:19: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  557 |         char nbuf[UINTMAX_STRSIZE_BOUND];
      |                   ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:92:50: error: expected expression before 'uintmax_t'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                                                  ^~~~~~~~~
tar-sparse.c:73:37: note: in definition of macro 'INT_BITS_STRLEN_BOUND'
   73 | #define INT_BITS_STRLEN_BOUND(b) (((b) * 146 + 484) / 485)
      |                                     ^
tar-sparse.c:90:31: note: in expansion of macro 'INT_STRLEN_BOUND'
   90 | #define INT_BUFSIZE_BOUND(t) (INT_STRLEN_BOUND (t) + 1)
      |                               ^~~~~~~~~~~~~~~~
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:557:19: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  557 |         char nbuf[UINTMAX_STRSIZE_BOUND];
      |                   ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:92:50: error: expected expression before 'uintmax_t'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                                                  ^~~~~~~~~
tar-sparse.c:86:36: note: in definition of macro 'INT_STRLEN_BOUND'
   86 |         + _GL_SIGNED_TYPE_OR_EXPR (t))
      |                                    ^
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:557:19: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  557 |         char nbuf[UINTMAX_STRSIZE_BOUND];
      |                   ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:92:50: error: expected expression before 'uintmax_t'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                                                  ^~~~~~~~~
tar-sparse.c:73:37: note: in definition of macro 'INT_BITS_STRLEN_BOUND'
   73 | #define INT_BITS_STRLEN_BOUND(b) (((b) * 146 + 484) / 485)
      |                                     ^
tar-sparse.c:90:31: note: in expansion of macro 'INT_STRLEN_BOUND'
   90 | #define INT_BUFSIZE_BOUND(t) (INT_STRLEN_BOUND (t) + 1)
      |                               ^~~~~~~~~~~~~~~~
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:103:26: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  103 |         if (dst == buf + UINTMAX_STRSIZE_BOUND - 1)                      \
      |                          ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:571:9: note: in expansion of macro 'COPY_BUF'
  571 |         COPY_BUF (archive, blk, nbuf, p);
      |         ^~~~~~~~
tar-sparse.c:92:50: error: expected expression before 'uintmax_t'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                                                  ^~~~~~~~~
tar-sparse.c:73:37: note: in definition of macro 'INT_BITS_STRLEN_BOUND'
   73 | #define INT_BITS_STRLEN_BOUND(b) (((b) * 146 + 484) / 485)
      |                                     ^
tar-sparse.c:90:31: note: in expansion of macro 'INT_STRLEN_BOUND'
   90 | #define INT_BUFSIZE_BOUND(t) (INT_STRLEN_BOUND (t) + 1)
      |                               ^~~~~~~~~~~~~~~~
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:103:26: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  103 |         if (dst == buf + UINTMAX_STRSIZE_BOUND - 1)                      \
      |                          ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:571:9: note: in expansion of macro 'COPY_BUF'
  571 |         COPY_BUF (archive, blk, nbuf, p);
      |         ^~~~~~~~
tar-sparse.c:92:50: error: expected expression before 'uintmax_t'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                                                  ^~~~~~~~~
tar-sparse.c:86:36: note: in definition of macro 'INT_STRLEN_BOUND'
   86 |         + _GL_SIGNED_TYPE_OR_EXPR (t))
      |                                    ^
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:103:26: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  103 |         if (dst == buf + UINTMAX_STRSIZE_BOUND - 1)                      \
      |                          ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:571:9: note: in expansion of macro 'COPY_BUF'
  571 |         COPY_BUF (archive, blk, nbuf, p);
      |         ^~~~~~~~
tar-sparse.c:92:50: error: expected expression before 'uintmax_t'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                                                  ^~~~~~~~~
tar-sparse.c:73:37: note: in definition of macro 'INT_BITS_STRLEN_BOUND'
   73 | #define INT_BITS_STRLEN_BOUND(b) (((b) * 146 + 484) / 485)
      |                                     ^
tar-sparse.c:90:31: note: in expansion of macro 'INT_STRLEN_BOUND'
   90 | #define INT_BUFSIZE_BOUND(t) (INT_STRLEN_BOUND (t) + 1)
      |                               ^~~~~~~~~~~~~~~~
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:103:26: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  103 |         if (dst == buf + UINTMAX_STRSIZE_BOUND - 1)                      \
      |                          ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:592:13: note: in expansion of macro 'COPY_BUF'
  592 |             COPY_BUF (archive, blk, nbuf, p);
      |             ^~~~~~~~
tar-sparse.c:92:50: error: expected expression before 'uintmax_t'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                                                  ^~~~~~~~~
tar-sparse.c:73:37: note: in definition of macro 'INT_BITS_STRLEN_BOUND'
   73 | #define INT_BITS_STRLEN_BOUND(b) (((b) * 146 + 484) / 485)
      |                                     ^
tar-sparse.c:90:31: note: in expansion of macro 'INT_STRLEN_BOUND'
   90 | #define INT_BUFSIZE_BOUND(t) (INT_STRLEN_BOUND (t) + 1)
      |                               ^~~~~~~~~~~~~~~~
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:103:26: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  103 |         if (dst == buf + UINTMAX_STRSIZE_BOUND - 1)                      \
      |                          ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:592:13: note: in expansion of macro 'COPY_BUF'
  592 |             COPY_BUF (archive, blk, nbuf, p);
      |             ^~~~~~~~
tar-sparse.c:92:50: error: expected expression before 'uintmax_t'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                                                  ^~~~~~~~~
tar-sparse.c:86:36: note: in definition of macro 'INT_STRLEN_BOUND'
   86 |         + _GL_SIGNED_TYPE_OR_EXPR (t))
      |                                    ^
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:103:26: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  103 |         if (dst == buf + UINTMAX_STRSIZE_BOUND - 1)                      \
      |                          ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:592:13: note: in expansion of macro 'COPY_BUF'
  592 |             COPY_BUF (archive, blk, nbuf, p);
      |             ^~~~~~~~
tar-sparse.c:92:50: error: expected expression before 'uintmax_t'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                                                  ^~~~~~~~~
tar-sparse.c:73:37: note: in definition of macro 'INT_BITS_STRLEN_BOUND'
   73 | #define INT_BITS_STRLEN_BOUND(b) (((b) * 146 + 484) / 485)
      |                                     ^
tar-sparse.c:90:31: note: in expansion of macro 'INT_STRLEN_BOUND'
   90 | #define INT_BUFSIZE_BOUND(t) (INT_STRLEN_BOUND (t) + 1)
      |                               ^~~~~~~~~~~~~~~~
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:103:26: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  103 |         if (dst == buf + UINTMAX_STRSIZE_BOUND - 1)                      \
      |                          ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:599:13: note: in expansion of macro 'COPY_BUF'
  599 |             COPY_BUF (archive, blk, nbuf, p);
      |             ^~~~~~~~
tar-sparse.c:92:50: error: expected expression before 'uintmax_t'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                                                  ^~~~~~~~~
tar-sparse.c:73:37: note: in definition of macro 'INT_BITS_STRLEN_BOUND'
   73 | #define INT_BITS_STRLEN_BOUND(b) (((b) * 146 + 484) / 485)
      |                                     ^
tar-sparse.c:90:31: note: in expansion of macro 'INT_STRLEN_BOUND'
   90 | #define INT_BUFSIZE_BOUND(t) (INT_STRLEN_BOUND (t) + 1)
      |                               ^~~~~~~~~~~~~~~~
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:103:26: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  103 |         if (dst == buf + UINTMAX_STRSIZE_BOUND - 1)                      \
      |                          ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:599:13: note: in expansion of macro 'COPY_BUF'
  599 |             COPY_BUF (archive, blk, nbuf, p);
      |             ^~~~~~~~
tar-sparse.c:92:50: error: expected expression before 'uintmax_t'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                                                  ^~~~~~~~~
tar-sparse.c:86:36: note: in definition of macro 'INT_STRLEN_BOUND'
   86 |         + _GL_SIGNED_TYPE_OR_EXPR (t))
      |                                    ^
tar-sparse.c:92:31: note: in expansion of macro 'INT_BUFSIZE_BOUND'
   92 | #define UINTMAX_STRSIZE_BOUND INT_BUFSIZE_BOUND (uintmax_t)
      |                               ^~~~~~~~~~~~~~~~~
tar-sparse.c:103:26: note: in expansion of macro 'UINTMAX_STRSIZE_BOUND'
  103 |         if (dst == buf + UINTMAX_STRSIZE_BOUND - 1)                      \
      |                          ^~~~~~~~~~~~~~~~~~~~~
tar-sparse.c:599:13: note: in expansion of macro 'COPY_BUF'
  599 |             COPY_BUF (archive, blk, nbuf, p);
      |             ^~~~~~~~
tar-sparse.c:557:14: warning: unused variable 'nbuf' [-Wunused-variable]
  557 |         char nbuf[UINTMAX_STRSIZE_BOUND];
      |              ^~~~
make[4]: *** [Makefile:527: tar-sparse.lo] Error 1
make[4]: Leaving directory '/root/rpmbuild/BUILD/mc-4.8.33-build/mc-4.8.33/src/vfs/tar'
make[3]: *** [Makefile:603: all-recursive] Error 1
make[3]: Leaving directory '/root/rpmbuild/BUILD/mc-4.8.33-build/mc-4.8.33/src/vfs'
make[2]: *** [Makefile:716: all-recursive] Error 1
make[2]: Leaving directory '/root/rpmbuild/BUILD/mc-4.8.33-build/mc-4.8.33/src'
make[1]: *** [Makefile:599: all-recursive] Error 1
make[1]: Leaving directory '/root/rpmbuild/BUILD/mc-4.8.33-build/mc-4.8.33'
make: *** [Makefile:529: all] Error 2

Change History

comment:1 Changed 7 weeks ago by zaytsev

Owner set to andrew_b
Status changed from new to assigned
Description modified (diff)
Milestone changed from Future Releases to 4.8.33

comment:2 Changed 7 weeks ago by zaytsev

Can reproduce on FC40, has to do with tar updates :-/

comment:3 follow-up: ↓ 5 Changed 7 weeks ago by andrew_b

Does your system have stdckdint.h under /usr/include?

comment:4 Changed 7 weeks ago by andrew_b

Component changed from mc-core to compilation

comment:5 in reply to: ↑ 3 Changed 7 weeks ago by Axanar

Replying to andrew_b:

Does your system have stdckdint.h under /usr/include?

Under Fedora you find it in this directory:

/usr/lib/gcc/x86_64-redhat-linux/14/include/stdckdint.h

comment:6 Changed 7 weeks ago by andrew_b

Blocking 4595 added

comment:7 Changed 7 weeks ago by andrew_b

Branch state changed from no branch to on review

Branch: 4593_tar_compilation
Initial changeset:400ae10a22588e295dbcf5b15e35d3b3097f3260

comment:8 Changed 7 weeks ago by zaytsev

With this change it compiles, but there are warnings. I will try to capture them. Strange for me that it works even though the backslashes in Makefile.am are apparently missing o_O

comment:9 Changed 7 weeks ago by zaytsev

zaytsev@fedora:~$ locate stdckdint.h
/usr/lib/gcc/aarch64-redhat-linux/14/include/stdckdint.h

comment:10 follow-up: ↓ 12 Changed 7 weeks ago by zaytsev

../../src/usermenu.c: In function 'user_menu_cmd':
../../src/usermenu.c:1044:56: warning: comparison of integer expressions of different signedness: 'int' and 'guint' {aka 'unsigned int'} [-Wsign-compare]
 1044 |         if (col == 0 && (entries == NULL || menu_lines == entries->len))
      |                                                        ^~
../../src/usermenu.c:1106:49: warning: comparison of integer expressions of different signedness: 'guint' {aka 'unsigned int'} and 'int' [-Wsign-compare]
 1106 |             if (entries != NULL && entries->len > menu_lines)
      |                                                 ^
../../src/usermenu.c:1135:27: warning: comparison of integer expressions of different signedness: 'int' and 'guint' {aka 'unsigned int'} [-Wsign-compare]
 1135 |             for (i = 0; i < entries->len; i++)
      |                           ^
../../src/usermenu.c:979:9: warning: unused variable 'menu_limit' [-Wunused-variable]
  979 |     int menu_limit = 0;
      |         ^~~~~~~~~~
  CC       util.lo

comment:11 Changed 7 weeks ago by zaytsev

Ubuntu 24.04:

zaytsev@ubuntu-24-04:~/src/mc/build$ locate stdckdint.h
/home/zaytsev/src/mc/lib/stdckdint.h

comment:12 in reply to: ↑ 10 Changed 7 weeks ago by andrew_b

Replying to zaytsev:

../../src/usermenu.c: In function 'user_menu_cmd':

This is not relevant to the ticket topic (tar). It can be fixed in the cleanup branch. But after #4592.

comment:13 follow-up: ↓ 15 Changed 7 weeks ago by zaytsev

The ticket topic is "fix broken build and warnings after cleanup was merged". Yes, you are right: most of them are because of the tar update. But why not just fix the others, which were also introduced by cleanup in this ticket? It's one extra commit.

comment:14 Changed 7 weeks ago by zaytsev

Strange for me that it works even though the backslashes in Makefile.am are apparently missing o_O

https://automake.gnu.narkive.com/ykDIgqyQ/backslashes-in-variable-definition

Apparently it's a known behavior (!?) - if backslashes are missing, then files are silently ignored by Automake. But because these are header files, and they existed in the source tree, the build did not fail.

comment:15 in reply to: ↑ 13 Changed 7 weeks ago by andrew_b

Replying to zaytsev:

It's one extra commit.

Ok. Two extra commits were added.

comment:16 Changed 7 weeks ago by zaytsev

Votes for changeset set to zaytsev
Branch state changed from on review to approved

Now compiles without warnings on Fedora 40. Thank you!

comment:17 Changed 7 weeks ago by Axanar

Now compiles on Fedora 41. Thank you!

Branch: 4593_tar_compilation

Passes RPM Hardening rules and compiles with rpmbuild!

comment:18 Changed 7 weeks ago by andrew_b

Status changed from assigned to testing
Votes for changeset changed from zaytsev to committed-master
Resolution set to fixed
Branch state changed from approved to merged

Merged to master: [5e2a484b9207a334e08036ede5bdec656e67e574].

git log --oneline f46406473..5e2a484b9

Last edited 5 weeks ago by andrew_b (previous) (diff)

comment:19 Changed 7 weeks ago by andrew_b

Status changed from testing to closed

Note: See TracTickets for help on using tickets.

Download in other formats: