Ticket #4572 (new task)
Prepare for release mc-4.8.33
Reported by: | zaytsev | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 4.8.33 |
Component: | adm | Version: | |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Branch state: | no branch | Votes for changeset: |
Description
Attachments
Change History
Changed 10 days ago by zaytsev
- Attachment 0001-buildsys-remove-orphaned-rpc-checks-after-samba-was-.patch added
comment:3 Changed 4 days ago by zaytsev
Clang reports:
../../../src/filemanager/mountlist.c:1218:3: warning: unused label 'free_then_fail' [-Wunused-label] 1218 | free_then_fail: | ^~~~~~~~~~~~~~~
Do I understand correctly that it doesn't make sense to fix it, because this code is copied from elsewhere and will be overwritten upon the next sync?
comment:4 Changed 4 days ago by zaytsev
Also tar stuff produces a lot of warnings:
CC tar-internal.lo ../../../../src/vfs/tar/tar-internal.c:403:47: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 403 | return tar_from_header (p, s, "off_t", 0, TYPE_MAXIMUM (off_t), FALSE); | ^~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:64:35: note: expanded from macro 'TYPE_MAXIMUM' 64 | #define TYPE_MAXIMUM(t) (~(t) 0 - TYPE_MINIMUM (t)) | ^~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ 1 warning generated. CC tar-sparse.lo ../../../../src/vfs/tar/tar-sparse.c:703:40: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 703 | if (!decode_num (&u, nbuf, TYPE_MAXIMUM (off_t))) | ^~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:64:35: note: expanded from macro 'TYPE_MAXIMUM' 64 | #define TYPE_MAXIMUM(t) (~(t) 0 - TYPE_MINIMUM (t)) | ^~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar-sparse.c:710:66: warning: comparison of integers of different signs: 'off_t' (aka 'long long') and 'unsigned long long' [-Wsign-compare] 710 | if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) || INT_ADD_OVERFLOW (sp.offset, u) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-sparse.c:193:35: note: expanded from macro 'INT_ADD_OVERFLOW' 193 | _GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-sparse.c:134:3: note: expanded from macro '_GL_BINARY_OP_OVERFLOW' 134 | op_result_overflow (a, b, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 135 | _GL_INT_MINIMUM (_GL_INT_CONVERT (a, b)), \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 136 | _GL_INT_MAXIMUM (_GL_INT_CONVERT (a, b))) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-sparse.c:169:21: note: expanded from macro '_GL_ADD_OVERFLOW' 169 | : (b) < 0 ? (a) <= (a) + (b) \ | ~ ^ ~~~~~~~~~ 2 warnings generated. CC tar-xheader.lo ../../../../src/vfs/tar/tar-xheader.c:313:16: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 313 | time_t s = TYPE_MINIMUM (time_t); | ^~~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar-xheader.c:330:40: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 330 | if (TYPE_SIGNED (time_t) ? TYPE_MINIMUM (time_t) <= i : 0 <= i) | ^~~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar-xheader.c:340:22: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 340 | if (i <= TYPE_MAXIMUM (time_t)) | ^~~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:64:35: note: expanded from macro 'TYPE_MAXIMUM' 64 | #define TYPE_MAXIMUM(t) (~(t) 0 - TYPE_MINIMUM (t)) | ^~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar-xheader.c:378:30: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 378 | if (s == TYPE_MINIMUM (time_t)) | ^~~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar-xheader.c:330:69: warning: code will never be executed [-Wunreachable-code] 330 | if (TYPE_SIGNED (time_t) ? TYPE_MINIMUM (time_t) <= i : 0 <= i) | ^ ../../../../src/vfs/tar/tar-xheader.c:604:31: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 604 | if (!decode_num (&u, arg, TYPE_MAXIMUM (off_t), keyword)) | ^~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:64:35: note: expanded from macro 'TYPE_MAXIMUM' 64 | #define TYPE_MAXIMUM(t) (~(t) 0 - TYPE_MINIMUM (t)) | ^~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar-xheader.c:807:31: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 807 | if (!decode_num (&u, arg, TYPE_MAXIMUM (off_t), keyword)) | ^~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:64:35: note: expanded from macro 'TYPE_MAXIMUM' 64 | #define TYPE_MAXIMUM(t) (~(t) 0 - TYPE_MINIMUM (t)) | ^~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar-xheader.c:846:31: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 846 | if (!decode_num (&u, arg, TYPE_MAXIMUM (off_t), keyword)) | ^~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:64:35: note: expanded from macro 'TYPE_MAXIMUM' 64 | #define TYPE_MAXIMUM(t) (~(t) 0 - TYPE_MINIMUM (t)) | ^~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar-xheader.c:901:13: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 901 | if (TYPE_MAXIMUM (off_t) < u) | ^~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:64:35: note: expanded from macro 'TYPE_MAXIMUM' 64 | #define TYPE_MAXIMUM(t) (~(t) 0 - TYPE_MINIMUM (t)) | ^~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar-xheader.c:903:17: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 903 | u = TYPE_MAXIMUM (off_t); | ^~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:64:35: note: expanded from macro 'TYPE_MAXIMUM' 64 | #define TYPE_MAXIMUM(t) (~(t) 0 - TYPE_MINIMUM (t)) | ^~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ 10 warnings generated. CC tar.lo ../../../../src/vfs/tar/tar.c:185:46: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 185 | return tar_from_header (p, s, "major_t", TYPE_MINIMUM (major_t), TYPE_MAXIMUM (major_t), FALSE); | ^~~~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar.c:185:70: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 185 | return tar_from_header (p, s, "major_t", TYPE_MINIMUM (major_t), TYPE_MAXIMUM (major_t), FALSE); | ^~~~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:64:35: note: expanded from macro 'TYPE_MAXIMUM' 64 | #define TYPE_MAXIMUM(t) (~(t) 0 - TYPE_MINIMUM (t)) | ^~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar.c:193:46: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 193 | return tar_from_header (p, s, "minor_t", TYPE_MINIMUM (minor_t), TYPE_MAXIMUM (minor_t), FALSE); | ^~~~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar.c:193:70: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 193 | return tar_from_header (p, s, "minor_t", TYPE_MINIMUM (minor_t), TYPE_MAXIMUM (minor_t), FALSE); | ^~~~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:64:35: note: expanded from macro 'TYPE_MAXIMUM' 64 | #define TYPE_MAXIMUM(t) (~(t) 0 - TYPE_MINIMUM (t)) | ^~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar.c:238:45: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 238 | return tar_from_header (p, s, "time_t", TYPE_MINIMUM (time_t), TYPE_MAXIMUM (time_t), FALSE); | ^~~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ ../../../../src/vfs/tar/tar.c:238:68: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 238 | return tar_from_header (p, s, "time_t", TYPE_MINIMUM (time_t), TYPE_MAXIMUM (time_t), FALSE); | ^~~~~~~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:64:35: note: expanded from macro 'TYPE_MAXIMUM' 64 | #define TYPE_MAXIMUM(t) (~(t) 0 - TYPE_MINIMUM (t)) | ^~~~~~~~~~~~~~~~ ../../../../src/vfs/tar/tar-internal.h:63:51: note: expanded from macro 'TYPE_MINIMUM' 63 | #define TYPE_MINIMUM(t) (TYPE_SIGNED (t) ? ~(t) 0 << (sizeof (t) * CHAR_BIT - 1) : (t) 0) | ~~~~~~ ^ 6 warnings generated.
Note: See
TracTickets for help on using
tickets.
Branch: 4572_cleanup
Initial changeset:a5ef01660badac0fff3a6e9e1904409a1fea37c7