Ticket #4560 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

Segfault when attempt to enter deleted archive (in extfs_open_and_read_archive())

Reported by: cieply Owned by: andrew_b
Priority: major Milestone: 4.8.32
Component: mc-vfs Version: 4.8.31
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

I stumbled upon this error when mc segfaulted when tried to open/enter archive.
Turned out the archive was deleted in other terminal but still was on the screen of mc in the first one.
Same crash happens with zip, 7z, rar but not with tar. The latter shows error box: \`Cannot open tar archive\n /path/to/file'.

To reproduce one needs to put archive (any, but tar) somewhere, switch to another terminal and delete that file. Then switch back to the first mc and enter the archive.

According to gdb it happens in extfs_open_and_read_archive() function (log attached).

Attachments

mc-4.8.31-g-extfs_open_and_read_archive-sigsegv.log.gz (1.1 KB) - added by cieply 4 months ago.

Change History

comment:1 Changed 4 months ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone set to 4.8.32

Branch: 4560_extfs_open_deleted_archive
changeset:f3a936d9a52582f6f7bcf0e2a8313682705a2b35

comment:2 Changed 4 months ago by cieply

Checked that patch - it works.

comment:3 Changed 4 months ago by andrew_b

  • Votes for changeset set to cieply andrew_b
  • Branch state changed from on review to approved

Thanks!

comment:4 Changed 4 months ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from cieply andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:5 Changed 4 months ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.