Ticket #44 (closed enhancement: fixed) — at Version 11
savannah: More functionally u7z
Reported by: | sgh | Owned by: | slavazanko |
---|---|---|---|
Priority: | major | Milestone: | 4.7.0-pre3 |
Component: | mc-vfs | Version: | master |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Branch state: | merged | Votes for changeset: | commited-master |
Description (last modified by ossi) (diff)
Original: http://savannah.gnu.org/bugs/?16303
Submitted by: | SGh <sgh> | Submitted on: | Sat 08 Apr 2006 01:43:59 PM UTC |
Category: | VFS | Severity: | 3 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | None | Open/Closed: | Open |
Release: | current (CVS or snapshot) | Operating System: | GNU/Linux |
Original submission:
I have mc CVS 2005-08-10-19 installed, I found, that I can't delete form 7z archives, and can't do some other operations (i.e. mc u7z cannot properly handle old 7z archives with ".\" at the beginning of filename)... So I wrote my own u7z version with all functionality, that provide p7zip archiver. Please include it to the mc source code.
Comment 1 by SGh <sgh> at Sat 08 Apr 2006 01:45:08 PM UTC:
P.S. Sorry for my bad english.
Comment 2 by Pavel Tsekov <ptsekov> at Thu 18 May 2006 01:51:52 PM UTC:
It would be better if you tweak the existing u7z script instead of providing a new one. I see the exisiting one has support for removing files from archives - why doesn't it work for you ? Does it print an error message of some kind ?
Comment 3 by SGh <sgh> at Tue 30 May 2006 07:52:33 PM UTC:
What's the difference if I've wrote my own version or changed the existent one? I've written it just a bit earlier before I've downloaded the CVS. I don't exactly remember but deleting wasn't worked in that CVS anyway. Seems like there was just an empty delete function.
Comment 4 by Leonard den Ottolander <leonardjo> at Wed 21 Jun 2006 05:35:56 PM UTC:
It's easier to see what changed (and if there are unwanted regressions) if you patch the existing version instead of writing a new version from scratch. So if you want to get any improvements considered for inclusion you will have to rewrite your patch.
Comment 5 by SGh <sgh> at Wed 21 Jun 2006 07:15:35 PM UTC:
OK, Understand. I will download latest CVS, and see if I have something to patch un u7z.
Comment 6 by SGh <sgh> at Fri 23 Jun 2006 11:06:44 PM UTC:
Here is my patch to original u7z, fixed things: 1) Detection if we have 7z or only 7za installed. (With 7z we can work with all 7z-supported archives, i.e. CABs, etc... Only have to rename this script in ucab.) 2) Workaround for old version p7zip archives with prefix ./ in filenames. 3) Fixed directory creation in mcu7zip_mkdir, now it works properly.
Change History
comment:2 Changed 15 years ago by winnie
- Status changed from new to accepted
- Owner set to winnie
- severity set to no branch
comment:6 Changed 15 years ago by slavazanko
- Version set to master
- severity changed from no branch to on review
As fact, attached patch already applied to master.
Branch 44_more_functionally_u7z created for some little bugfixies.
initial changeset:c057bff00c235a2c439c669979e1aee739065046
review, please.
comment:8 Changed 15 years ago by angel_il
- Votes for changeset changed from iNode to iNode angel_il
- severity changed from on review to approved
comment:9 Changed 15 years ago by slavazanko
- Status changed from accepted to testing
- Votes for changeset changed from iNode angel_il to commited-master
- Resolution set to fixed
- severity changed from approved to merged
comment:11 Changed 11 years ago by ossi
- Description modified (diff)
- Branch state set to no branch
- Reporter changed from slavazanko to sgh
added by sgh