Ticket #4494 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

tar VFS problem in 4.8.30

Reported by: Toolybird Owned by: andrew_b
Priority: major Milestone: 4.8.31
Component: mc-vfs Version: 4.8.30
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

There is an odd problem with tar VFS in 4.8.30. The problem does not exhibit in 4.8.29. I am on Arch Linux and at least 1 other user can reproduce the issue.

Steps to reproduce:

  1. curl -O ​https://geo.mirror.pkgbuild.com/core/os/x86_64/gcc-13.2.1-3-x86_64.pkg.tar.zst
  2. open the file "gcc-13.2.1-3-x86_64.pkg.tar.zst" in mc
  3. navigate to /usr/bin inside the archive
  4. copy (F5) the file "gcc" somewhere e.g. /tmp
  5. outside of mc, execute `file /tmp/gcc'

It will show the file type as:

"POSIX tar archive"

When of course it should be:

"ELF 64-bit LSB executable"

I haven't git bisected (yet) but I do note some new tar functionality mentioned in the 4.8.30 release notes.

Thanks

Change History

comment:1 Changed 9 months ago by Toolybird

I haven't git bisected (yet)

Unfortunately the source is not git bisectable. It bombed out with a compilation failure at:

4158824d70b9d298b2e02c202ddfc77f7fd5dd82

comment:2 Changed 9 months ago by andrew_b

From ls -l:

-rwxr-xr-x 4 andrew andrew 1955824 Aug  2 10:06 c++
-rwxr-xr-x 4 andrew andrew 1955824 Aug  2 10:06 g++
-rwxr-xr-x 4 andrew andrew 1955824 Aug  2 10:06 x86_64-pc-linux-gnu-c++
-rwxr-xr-x 4 andrew andrew 1955824 Aug  2 10:06 x86_64-pc-linux-gnu-g++

These are hardlinks. Support of hardlinks is broken.

Last edited 9 months ago by andrew_b (previous) (diff)

comment:3 Changed 9 months ago by andrew_b

Bad commit is [8223f82857bfb7d3a84214242da18061feb49315].

comment:4 Changed 9 months ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Component changed from mc-core to mc-vfs
  • Milestone changed from Future Releases to 4.8.31

comment:5 Changed 9 months ago by andrew_b

  • Branch state changed from no branch to on review

Branch: 4494_tar_hardlinks
changeset:bba6f5fa84ae8cd4f54123fbca51364e7ee51539

comment:6 Changed 9 months ago by Toolybird

Thanks for the patch! It solves the problem for me.

comment:7 Changed 9 months ago by andrew_b

  • Votes for changeset set to Toolybird andrew_b
  • Branch state changed from on review to approved

Thanks for the feedback!

comment:8 Changed 9 months ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from Toolybird andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [2849d5080edfacd29fa05ea4880fc51f0e7c3d39].

comment:9 Changed 9 months ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.