Ticket #4493 (closed defect: fixed)
mc-4.8.30 fails to build on FreeBSD with ext2fs attribute support
Reported by: | phil | Owned by: | andrew_b |
---|---|---|---|
Priority: | major | Milestone: | 4.8.31 |
Component: | compilation | Version: | 4.8.30 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Branch state: | merged | Votes for changeset: | committed-master |
Description
Attachments
Change History
Changed 16 months ago by phil
- Attachment patch-mc-src_vfs_local_Makefile.am.patch added
comment:1 Changed 16 months ago by andrew_b
There is no such issue on Linux. Please show config.log and output of make.
comment:2 Changed 16 months ago by phil
Attached config.log. Relevant output of make:
Making all in local gmake[6]: Entering directory '/usr/home/phil/freebsd-ports/misc/mc/work/mc-4.8.30/src/vfs/local' /bin/sh ../../../libtool --tag=CC --mode=compile cc -DHAVE_CONFIG_H -I. -I../../.. -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/ local/include -I../../.. -I/usr/local/include -DLIBICONV_PLUG -I/usr/local/include -I/usr/local/include -I/usr/local/include -Wassign-enum -Wbad-function- cast -Wcomment -Wconditional-uninitialized -Wdeclaration-after-statement -Wfloat-conversion -Wfloat-equal -Wformat -Wformat-security -Wimplicit -Wimplicit-fal lthrough -Wignored-qualifiers -Wlogical-not-parentheses -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers -Wmissing-format-attribute -Wmiss ing-prototypes -Wmissing-variable-declarations -Wnested-externs -Wno-long-long -Wno-unreachable-code -Wparentheses -Wpointer-arith -Wpointer-sign -Wredundant-decls -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wstrict-prototypes -Wswitch -Wswitch-default -Wtype-limits -Wundef -Wuninitialized -Wunreachable-code -Wunused-but-set-variable -Wunused-function -Wunused-label -Wunused-parameter -Wunused-result -Wunused-value -Wunused-variable -Wwrite-strings -O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing -MT local.lo -MD -MP -MF .deps/local.Tpo -c -o local.lo local.c libtool: compile: cc -DHAVE_CONFIG_H -I. -I../../.. -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I../../.. -I/usr/local/include -DLIBICONV_PLUG -I/usr/local/include -I/usr/local/include -I/usr/local/include -Wassign-enum -Wbad-function-cast -Wcomment -Wconditional-uninitialized -Wdeclaration-after-statement -Wfloat-conversion -Wfloat-equal -Wformat -Wformat-security -Wimplicit -Wimplicit-fallthrough -Wignored-qualifiers -Wlogical-not-parentheses -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-prototypes -Wmissing-variable-declarations -Wnested-externs -Wno-long-long -Wno-unreachable-code -Wparentheses -Wpointer-arith -Wpointer-sign -Wredundant-decls -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -Wstrict-prototypes -Wswitch -Wswitch-default -Wtype-limits -Wundef -Wuninitialized -Wunreachable-code -Wunused-but-set-variable -Wunused-function -Wunused-label -Wunused-parameter -Wunused-result -Wunused-value -Wunused-variable -Wwrite-strings -O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing -MT local.lo -MD -MP -MF .deps/local.Tpo -c local.c -fPIC -DPIC -o .libs/local.o local.c:35:10: fatal error: 'e2p/e2p.h' file not found #include <e2p/e2p.h> /* fgetflags(), fsetflags() */ ^~~~~~~~~~~ 1 error generated. gmake[6]: *** [Makefile:513: local.lo] Error 1
comment:3 Changed 16 months ago by phil
I simply copied the fix from the other piece of code that uses e2p, src/filemanager/Makefile.am.
comment:4 follow-up: ↓ 5 Changed 16 months ago by andrew_b
Please test the attached 4493_ext2fs_cppflags.patch.
comment:5 in reply to: ↑ 4 Changed 16 months ago by phil
Replying to andrew_b:
Please test the attached 4493_ext2fs_cppflags.patch.
Thanks, your patch also works fine.
comment:6 follow-up: ↓ 10 Changed 16 months ago by andrew_b
- Status changed from new to accepted
- Owner set to andrew_b
- Branch state changed from no branch to on review
Branch: 4493_FTBFS_FreeBSD.
changeset:9688e7d015d1744e3d22d2ec64ae56222eb9259d
comment:7 Changed 16 months ago by andrew_b
- Votes for changeset set to phil andrew_b
- Branch state changed from on review to approved
comment:8 Changed 16 months ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from phil andrew_b to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [c56c4f63ccb245eb5e25d71230b906f6b852b92d].
comment:10 in reply to: ↑ 6 ; follow-up: ↓ 11 Changed 16 months ago by phil
Replying to andrew_b:
Branch: 4493_FTBFS_FreeBSD.
changeset:9688e7d015d1744e3d22d2ec64ae56222eb9259d
Probably it's too late, but there's a typo in your commit message: this is ticket 4493, not the number that ended up in the message.
comment:11 in reply to: ↑ 10 Changed 16 months ago by andrew_b
Replying to phil:
Probably it's too late
Unfortunately yes. Commits in the master branch are unmodifiable.
but there's a typo in your commit message: this is ticket 4493
Yet another my such typo. :-(
Proposed patch