Ticket #4485 (closed enhancement: fixed)

Opened 2 months ago

Last modified 2 months ago

patchfs: add details to error message

Reported by: rillig Owned by: andrew_b
Priority: major Milestone: 4.8.30
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: andrew_b


I tried opening a patch file generated by CVS via patchfs, and all I got was:

Unrecognized character in hunk

It would have been helpful to know which character was unrecognized, and the line number. With that knowledge, I would have been able to preprocess the patch file so that patchfs understands it.

I looked around to find how to copy the existing patchfs to modify it locally, but didn't find any config file or documentation. From looking at mc.ext, it seemed that there is a hard-coded list of filesystems. But that's an entirely different topic.

Change History

comment:2 Changed 2 months ago by rillig

Patchfs didn't accept my patch files because I had the line 'diff -upNT' in my .cvsrc, which caused the first character of each hunk line to be a tab instead of a space. This would be a nice addition to patchfs as well.

comment:3 Changed 2 months ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.30

Thanks for the patch!

Branch: 4485_patchfs

comment:4 Changed 2 months ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:5 Changed 2 months ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:6 Changed 2 months ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.