Ticket #4466 (closed defect: fixed)

Opened 18 months ago

Last modified 18 months ago

"make dist" failed with error in "po" dir

Reported by: karlson2k Owned by: andrew_b
Priority: major Milestone: 4.8.30
Component: compilation Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

This is a follow-up for #4459.

po directory needs to be treated specially. It does not fully use automake macros and SED is not substituted in generated Makefiles.
The only way to add new automatically substituted variable to the Makefile is to add it to Makefile.in.in, however this file is replaced automatically by autopoint (with -f flag).
All other files, like Makevars or Rules-pot-defaults, are not processed by configure for variable substitution.
The best way to use sed command in this dir is to rely on shell automatic substitution. It does not use sed found by configure, but the script is portable enough, so with the suggest patch "make dist" works without overcomplication.

The suggested fix: https://github.com/MidnightCommander/mc/pull/191

Attachments

0001-Fix-sed-usage-in-po-Makefile.patch (796 bytes) - added by karlson2k 18 months ago.
Suggested fix

Change History

Changed 18 months ago by karlson2k

Suggested fix

comment:1 Changed 18 months ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Milestone changed from Future Releases to 4.8.30

comment:2 Changed 18 months ago by andrew_b

  • Branch state changed from no branch to on review

comment:3 Changed 18 months ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:4 Changed 18 months ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Thanks!

Merged to master: [ec3f142b86a1d900587798c0e649216fc1db1d2a].

comment:5 Changed 18 months ago by andrew_b

  • Status changed from testing to closed

comment:6 Changed 18 months ago by karlson2k

You are welcome.

I've tested the git master. Now dist could be made (tested on Debian Sid) and then mc could be built on Solaris.

Last edited 18 months ago by karlson2k (previous) (diff)
Note: See TracTickets for help on using tickets.