Ticket #4463 (closed defect: fixed)
ncurses library is duplicated in MCLIBS
| Reported by: | karlson2k | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.8.30 |
| Component: | compilation | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
AC_SEARCH_LIBS macro adds required library to 'LIBS' variable.
Currently 'LIBS' could be appended to 'MCLIBS' several times leading to duplication of found values.
The suggested patches fix duplication for 'stdscr' function detection. Additionally patches fix potential problematic situation when 'addwstr' or 'has_colors' detected in one ncurses library (for example 'ncurses'), while 'stdscr' detected in other ncurses library (for example 'curses'). Such combination leads to problems.
Attachments
Change History
Changed 11 months ago by karlson2k
- Attachment 0001-configure-fix-duplication-of-ncurses-in-MCLIBS.patch added
comment:1 Changed 11 months ago by andrew_b
- Owner set to andrew_b
- Status changed from new to accepted
- Milestone changed from Future Releases to 4.8.30
comment:3 Changed 11 months ago by andrew_b
- Branch state changed from no branch to on review
Thanks for the patch!
Branch: 4463_ncurses_libs
changeset:92ae4c6b2027315d32059e8fed2c601a0dff1070
comment:4 Changed 11 months ago by andrew_b
- Votes for changeset set to andrew_b
- Branch state changed from on review to approved
comment:5 Changed 11 months ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [f17ebfd2a5c0f7e8a1284e2f1dc9119cfa0a1304].
Note: See
TracTickets for help on using
tickets.
