Ticket #4459 (closed defect: fixed)

Opened 14 months ago

Last modified 14 months ago

Usage of 'sed' in build system/makefiles is not portable

Reported by: karlson2k Owned by: andrew_b
Priority: major Milestone: 4.8.30
Component: compilation Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

In the build system the sed command used with unportable "inplace" options ("-i").
The leads to build failures on some platforms, like Solaris, and reduces portability in general.

Similar issues were fixed already in the past: https://midnight-commander.org/ticket/3479

The configure script is already detecting suitable sed command in LT_INIT macro, so it worth to use the result of this detection to reduce portability problems.

On the other hand, workaround for "inplace" use is very simple and straightforward, so for the best portability it would be better to avoid unportable sed commands.

POSIX sed specification: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html

Suggested fix: https://github.com/MidnightCommander/mc/pull/184

Change History

Changed 14 months ago by karlson2k

Changed 14 months ago by karlson2k

comment:1 Changed 14 months ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Component changed from mc-core to compilation
  • Milestone changed from Future Releases to 4.8.30

comment:2 Changed 14 months ago by andrew_b

  • Branch state changed from no branch to on review

comment:3 Changed 14 months ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:4 Changed 14 months ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [2e3e3a377570570394850ca04069894ca1ffaf79].

git log --pretty=oneline e5911c1ef..2e3e3a377

comment:5 Changed 14 months ago by andrew_b

  • Status changed from testing to closed

Thanks for the patches!

Note: See TracTickets for help on using tickets.