Paragraph formatting allows lines one character longer than the margin

[proski]

The default word wrap setting is 72 characters, but Alt-P acts as if the setting is 73 characters.

It turns out there is a bug in line_pixel_length(). When xn (the visual width) exceed l (the target width), b (the byte offset in the string and the returnable value) is still incremented before the for loop ends. That's how for loops work. But we want the byte offset after the last character that would fit, i.e. the non-incremented value.

The attached patch moves the increment of the return value to a separate line. The initial increment is not needed, so char_length starts with 0.

I've tested the patch with different charsets, including wide characters.

[proski]

Patch

[andrew_b]

Thanks!

Branch: 4446_paragraph_format
changeset:44c299c7847e6cb3616a16654dc6a426226a960c

[andrew_b]

Merged to master: [b1f061e4901028ac7590dba2c1e5d10b48567ecd].