Ticket #4433 (new enhancement) — at Initial Version

Opened 2 years ago

Last modified 13 months ago

Allow setting color for abnormal characters in editor from skin file

Reported by: ArtemKuchin Owned by:
Priority: minor Milestone: 4.8.31
Component: mc-skin Version: master
Keywords: color abnormal non printable skin Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset:

Description

in editdraw.c

/* If non-printable - use black background */
color = (style & MOD_ABNORMAL) != 0 ? 0 : p->style >> 16;

So, if, for example, file contains CR (M) i see a lot of M on black background tearing apart all my nice colors and poking my eyes out.
It would be nice to have something like editabnormal in skin file to set it to something noticeable but nice.

I tried adding it myself

skin.h
#define EDITOR_ABNORMAL_COLOR mc_skin_colorcache[50]
#define MC_SKIN_COLOR_CACHE_COUNT 68
and renumbered cache array

colors.c
EDITOR_ABNORMAL_COLOR = mc_skin_color_get ("editor", "editabnormal");

editdraw.c

else

tty_setcolor (EDITOR_ABNORMAL_COLOR);
tty_lowlevel_setcolor (color);

But it does not work somehow. Compiles fine but just does not work. Abnormal chars just show as normal.

Note: See TracTickets for help on using tickets.