Ticket #4404 (closed defect: fixed)

Opened 3 months ago

Last modified 2 months ago

wrong decompressor selected

Reported by: gyorokpeter Owned by: andrew_b
Priority: major Milestone: 4.8.29
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

When installing mc on Ubuntu 22.04 LTS (I tried both on a VM and under WSL) the wrong decompressor is chosen when pressing Enter on a file that is a zip file but doesn't have the .zip extension. In my case the file extension is ".qpk". The unzip command correctly extracts files from it, but apparently mc tries to unpack it as a gzip file instead, leading to the following error:
SFS virtual file system:gzip: stdin has more than one entry--rest ignored

***:~$ LC_MESSAGES=C mc -V 
GNU Midnight Commander 4.8.27 
Built with GLib 2.68.4 
Built with S-Lang 2.3.2 with terminfo database 
With builtin Editor and Aspell support 
With subshell support as default 
With support for background operations 
With mouse support on xterm and Linux console 
With support for X11 events 
With internationalization support 
With multiple codepages support 
With ext2fs attributes support 
Virtual File Systems: 
cpiofs, tarfs, sfs, extfs, ext2undelfs, ftpfs, sftpfs, fish 
Data types: 
char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64; 

***:~$ mc --configure-options 
'--build=x86_64-linux-gnu' '--prefix=/usr' '--includedir=${prefix}/include' '--mandir=${prefix}/share/man' '--infodir=${prefix}/share/info' '--sysconfdir=/etc' '--localstatedir=/var' '--disable-option-checking' '--libdir=${prefix}/lib/x86_64-linux-gnu' '--runstatedir=/run' '--disable-maintainer-mode' '--disable-dependency-tracking' 'AWK=awk' 'X11_WWW=x-www-browser' '--libexecdir=/usr/lib' '--with-x' '--with-screen=slang' '--disable-rpath' '--disable-static' '--disable-silent-rules' '--enable-aspell' '--enable-vfs-sftp' '--enable-vfs-undelfs' '--enable-tests' 'build_alias=x86_64-linux-gnu' 'CFLAGS=-g -O2 -ffile-prefix-map=/build/mc-EOIzsU/mc-4.8.27=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security' 'LDFLAGS=-Wl,-Bsymbolic-functions -flto=auto -Wl,-z,relro -Wl,-z,now -Wl,--as-needed' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 

***:~$ LC_MESSAGES=C mc -F 
Home directory: *** 
Profile root directory: *** 
  
[System data] 
    Config directory: /etc/mc/ 
    Data directory:   /usr/share/mc/ 
    File extension handlers: /usr/lib/mc/ext.d/ 
    VFS plugins and scripts: /usr/lib/mc/ 
        extfs.d:        /usr/lib/mc/extfs.d/ 
        fish:           /usr/lib/mc/fish/ 

[User data] 
    Config directory: ***/.config/mc/ 
    Data directory:   ***/.local/share/mc/ 
        skins:          ***/.local/share/mc/skins/ 
        extfs.d:        ***/.local/share/mc/extfs.d/ 
        fish:           ***/.local/share/mc/fish/ 
        mcedit macros:  ***/.local/share/mc/mc.macros 
        mcedit external macros: ***/.local/share/mc/mcedit/macros.d/macro.* 
    Cache directory:  ***/.cache/mc/

Change History

comment:1 Changed 2 months ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.29

Branch: 4404_zip_magic
Initial (1/2) changeset:a4d35edf187ef64d3551b1547f5420349d6f35c0

comment:2 Changed 2 months ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:3 Changed 2 months ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [e48cd98ac13a9b4366bd88287f632413766b967f].

git log --pretty=oneline 7bbaa1364..e48cd98ac

comment:4 Changed 2 months ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.