FISH download, file modification and access times truncated

[opty]

When downloading a file using FISH, it doesn't preserve (nano)seconds and even the whole time when copying from OpenWrt 19.07.7. Should FISH use ls --full-time?

Workaround: Use upload (if possible).

[opty]

ls --full-time without Perl (like OpenWrt), %S in strftime() with Perl and D instead of d in both.

Unfortunately, Perl's nanoseconds support through Time::HiRes seems problematic (floating point representation), so prefer ls over Perl?

[opty]

Trying to use %S with D in Perl leads to timezone (DST in my case) problem due to mktime(3) in C but just adding :%S to strftime() and keeping the d seems to work.

[opty]

So far (seconds):

usr/libexec/mc/fish/ls

@@ -5 +5 @@
 fish_list_lsq ()
 {
 FISH_DIR="$1"
-ls -Qlan "${FISH_DIR}" 2>/dev/null | grep '^[^cbt]' | (
-while read p l u g s m d y n; do
+ls -Qan --full-time "${FISH_DIR}" 2>/dev/null | grep '^[^cbt]' | (
+while read p l u g s d t z n; do
     echo "P$p $u.$g"
     echo "S$s"
-    echo "d$m $d $y"
+    echo "d${d#*-}-${d%%-*} ${t%.*}"
     echo ":$n"
     echo
 done
 )
 
-ls -Qlan "${FISH_DIR}" 2>/dev/null | grep '^[cb]' | (
-while read p l u g a i m d y n; do
+ls -Qan --full-time "${FISH_DIR}" 2>/dev/null | grep '^[cb]' | (
+while read p l u g a i d t z n; do
     echo "P$p $u.$g"
     echo "E$a$i"
-    echo "d$m $d $y"
+    echo "d${d#*-}-${d%%-*} ${t%.*}"
     echo ":$n"
     echo
 done
@@ -130 +130 @@
 if (opendir (DIR, $dirname)) {
 while((my $filename = readdir (DIR))){
     my ($dev,$ino,$mode,$nlink,$uid,$gid,$rdev,$size,$atime,$mtime,$ctime,$blksize,$blocks) = lstat("$dirname/$filename");
-    my $mloctime= strftime("%m-%d-%Y %H:%M", localtime $mtime);
+    my $mloctime= strftime("%m-%d-%Y %H:%M:%S", localtime $mtime);
     my $strutils_shell_escape_regex = s/([;<>\*\|`&\$!#\(\)\[\]\{\}:'\''"\ \\])/\\$1/g;
     my $e_filename = $filename;
     $e_filename =~ $strutils_shell_escape_regex;

[andrew_b]

ls --full-time is not portable. GNU ls has this option, but BSD hasn't.

[zaytsev]

Well, BSD doesn't seem to have -Q either - on my Mac:

zaytsev@Yurys-MBP ~ % ls -Qlan
ls: illegal option -- Q
usage: ls [-@ABCFGHLOPRSTUWabcdefghiklmnopqrstuwx1%] [file ...]

BSD has -T though, which shows at least seconds, but GNU uses it for something else :-(

I think that the helpers are named in a very confusing way:

• fish_list_lsq should be probably called fish_list_gnu
• fish_list_sed should be probably called fish_list_bsd
• fish_list_poor_ls should be probably called fish_list_busybox

This way the logic is more clear - Perl is used for maximal portability wherever it's available to ensure consistent results - otherwise use plain ls and POSIX stuff for three major userland types... At least this would be my logic if I tried to come up with helpers myself :-)

Also it's very annoying that each block is copy & pasted twice... so much for the use of functions.