Ticket #4269 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Fix use-after-free in edit_close_cmd

Reported by: cerg2010cerg2010 Owned by: andrew_b
Priority: major Milestone: 4.8.27
Component: mcedit Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

This is a simple fix of the issue found by PVS-Studio static code analyzer. I don't think you can trigger the bug now as I've found no paths which could lead to the edit_widget_is_editor condition being false.

Attachments

0001-src-editor-editcmd.c-Fix-use-after-free-in-edit_clos.patch​ (954 bytes) - added by cerg2010cerg2010 3 years ago.

Change History

Changed 3 years ago by cerg2010cerg2010

comment:1 Changed 3 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Milestone changed from Future Releases to 4.8.27

comment:2 Changed 3 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset set to committed-master
  • Resolution set to fixed
  • Branch state changed from no branch to merged

Thanks!

Applied as [2234fd83579d5a5ee93e4b995d280dd5b2d5a889].

comment:3 Changed 3 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.