Ticket #4248 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Recognize Alacritty as an xterm-compatible terminal emulator

Reported by: gszymaszek Owned by: andrew_b
Priority: trivial Milestone: 4.8.27
Component: mc-tty Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Alacritty is a “fast, cross-platform, OpenGL terminal emulator” (see ​Alacritty on GitHub). Add its default TERM value to the recognized ones. This enables mc to change window title and handle mouse events.

Attachments

0001-Add-alacritty-to-known-terminals.patch​ (1.5 KB) - added by gszymaszek 3 years ago.

Change History

Changed 3 years ago by gszymaszek

comment:1 follow-up: ↓ 2 Changed 3 years ago by andrew_b

Is only test of $TERM value enough? Does it work without

  • misc/mc.lib 

    diff --git a/misc/mc.lib b/misc/mc.lib
index bf8be065c..7a81f1028 100644
    a b copy=xterm 
    146146[terminal:tmux-256color] 
    147147copy=xterm 
    148148 
     149[terminal:alacritty] 
     150copy=xterm 
     151 
    149152[terminal:ibmpc3] 
    150153f11=\\e[Y 
    151154f12=\\e[Z 

?

comment:2 in reply to: ↑ 1 Changed 3 years ago by gszymaszek

(Replying to andrew_b.) I have commented out the above fragment in both /usr/share/mc/mc.lib (Debian testing) and $PREFIX/share/mc/mc.lib (my build) and it still works. I don’t see other mc.lib files in ~/.cache, ~/.config, nor ~/.local.

Version 0, edited 3 years ago by gszymaszek (next)

comment:3 Changed 3 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Milestone changed from Future Releases to 4.8.27

comment:4 Changed 3 years ago by andrew_b

  • Branch state changed from no branch to on review

Branch: 4248_alacritty
Initial changeset:2f3d59db36bc93d2f3ca89c1ce151e4664b74c1a

comment:5 Changed 3 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:6 Changed 3 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [167f437b1466cf289b7c04a149ee093033c2de72]

git log --pretty=oneline e4195219f..167f437b1

comment:7 Changed 3 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.