Ticket #4242 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

User menu entry with %view fails on no-exec filesystem.

Reported by: lkrotowski Owned by: andrew_b
Priority: major Milestone: 4.8.27
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

When tmp filesystem is no-exec user menu with %view fails to execute with error: can't execute: Permission denied. User menu without %view works fine. It's because in usermenu.c, in execute_menu_command() case without %view on no-exec filesystem is explicitly handled by executing script indirectly with /bin/sh.

Attached (ugly) patch copies that handling to %view case. And it seems to work for me.

Attachments

mc-view-on-no-exec-fs.patch​ (584 bytes) - added by lkrotowski 4 years ago.

Change History

Changed 4 years ago by lkrotowski

comment:1 Changed 4 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Milestone changed from Future Releases to 4.8.27

comment:2 Changed 4 years ago by andrew_b

  • Branch state changed from no branch to on review

Branch: 4242_usermenu_view_indirect
Initial changeset:d86bc9a554164fba0cdaface1446119ecd463d0d

comment:3 Changed 4 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:4 Changed 4 years ago by andrew_b

Merged to master: [83d4966807903ba2c70d049899bf563439d9a44f].

git log --pretty=oneline 3a457a2cb..83d496680

comment:5 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:6 Changed 4 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.