Ticket #4238 (new defect)

Opened 12 months ago

Last modified 6 weeks ago

uzip doesn't properly handle zip archives with backward slashes

Reported by: birdie Owned by:
Priority: trivial Milestone: Future Releases
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Attachments

bug.png (13.6 KB) - added by birdie 12 months ago.
Ruler.zip (159.5 KB) - added by birdie 12 months ago.
Another such bad zip file

Change History

comment:1 Changed 12 months ago by birdie

  • Summary changed from uzip doesn't properly handle zip archive with backward slashes to uzip doesn't properly handle zip archives with backward slashes

Changed 12 months ago by birdie

comment:2 Changed 12 months ago by birdie

unzip properly unpacks this archive anyway if you run

unzip ScreenRuler-v.0.8.1-Portable.zip

MC unpacks files improperly.

Changed 12 months ago by birdie

Another such bad zip file

comment:3 follow-ups: ↓ 4 ↓ 5 Changed 12 months ago by andrew_b

MC supports UNIX-like OSes only. Therefore MC VFS supports only "/" as path separator.

comment:4 in reply to: ↑ 3 Changed 12 months ago by birdie

Replying to andrew_b:

MC supports UNIX-like OSes only. Therefore MC VFS supports only "/" as path separator.

  1. Unix-like OSes should be able to work with archives created anywhere and everywhere by any application
  2. Unix-like OSes contain Wine which is able to run Windows software which, as you can see, is sometimes distributed in "improper" zip archives

This is a valid bug report, please fix.

comment:5 in reply to: ↑ 3 Changed 12 months ago by birdie

You personally may never bother with this issue: maybe some more interested people will come and take a look.

comment:6 Changed 12 months ago by andrew_b

  • Priority changed from minor to trivial

comment:7 Changed 12 months ago by ossi

oh, c'mon andrew, stop being a dick about everything that doesn't interest you personally. first you completely demotivated psprint, and now you're essentially telling birdie to fuck off even though the issue is very real and not trivial at all for those who are affected.

comment:9 Changed 6 weeks ago by birdie

It's an upstream bug so I went ahead and filed it:

https://sourceforge.net/p/infozip/bugs/67/

comment:10 Changed 6 weeks ago by andrew_b

Ticket #4365 has been marked as a duplicate of this ticket.

comment:11 Changed 6 weeks ago by zaytsev

I missed the comment about demotivating psprint last year - the problem is that the code he is generating is just too way off, and neither of us have time to rewrite everything he makes to turn it into something halfway sane. Maybe there will be better times in the future, but right now it's the way it is.

comment:12 Changed 6 weeks ago by ossi

i don't think that in psprint's case it's necessary to rewrite anything yourself - he's competent and motivated enough. but he needs strong guidance, and he's not getting it from those who have authority here.

but that discussion really doesn't belong into this ticket. i mentioned it only to provide an additional data point that the interaction with the community here isn't always constructive.

comment:13 Changed 6 weeks ago by zaytsev

The time required to provide "strong guidance" is a couple of orders of magnitude more than rewriting oneself, so I didn't even consider it. And once one makes time by some miracle and starts investing it, there are usually two cases - one when the guided becomes exponentially better quickly, and one when it drags on for months and the progress is marginal. At least this is what I experienced in the last decade in the industry. We tried what we could, but it looked like the second case and we don't have more to offer. Of course, you are welcome to succeed where we failed.

Anyways you are right about both points that 1) this discussion doesn't belong to this ticket and that 2) our interaction with the community is not always constructive. Delivering good interaction is hard and requires a lot of resources.

Note: See TracTickets for help on using tickets.