Ticket #4233 (closed defect: fixed)

Opened 6 months ago

Last modified 3 months ago

Enable xterm_flag in screen and tmux even without DISPLAY

Reported by: filip.hejsek Owned by: andrew_b
Priority: major Milestone: 4.8.27
Component: mc-tty Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Currently, the xterm_flag, and therefore mouse support, is only enabled with TERM=screen when the DISPLAY variable is set to nonempty value. However, this is not always the case (for example when using srceen/tmux over ssh), and the absence of the DISPLAY variable doesn't mean the terminal doesn't support mouse. The correct thing to do is to always enable mouse support under screen/tmux.

Additionally, while tmux by default sets TERM to "screen" for compatibility, it also supports "tmux" and "tmux-256color", so these should be detected too.

I was about to submit a pull request on github, but then i saw the message that you don't use github pull requests, so i submitted this ticket instead. The commit is here: https://github.com/filip-hejsek/mc/commit/01c7047ac4c6cd8595448b51dd45d6f769cf43db

Change History

comment:1 Changed 6 months ago by filip.hejsek

  • Summary changed from Enable xterm_flag in more screen and tmux even without DISPLAY to Enable xterm_flag in screen and tmux even without DISPLAY

comment:2 Changed 4 months ago by filip.hejsek

Ping?

comment:3 Changed 4 months ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.27

Branch: 4233_screen_tmux_mouse
Initial changeset:57a5db64ca8dc3f562bc223a053671c160d1f8f7

comment:4 Changed 3 months ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:5 Changed 3 months ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [5c1d3c55dd15356ec7d079084d904b7b0fd58d3e].

git log --pretty=oneline 0e6721c32..5c1d3c55d

comment:6 Changed 3 months ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.