Ticket #4207 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[patch][bug] Fix "Find declaration" disrupting file's path

Reported by: psprint Owned by: andrew_b
Priority: major Milestone: 4.8.27
Component: mcedit Version: master
Keywords: ctags,tags Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

  • Leaving a file for a TAGS symbol with "Find declaration",
  • and then going back with "Back from declaration",
  • causes filename_vpath in WEdit to be incorrect –
  • it'll have dir_vpath (WEdit) prepended.

That's because the code doesn't check if filename_vpath is already absolute before prepending. This patch fixes this.

​asciinema showing the bug.

Attachments

FindTagSymbol.patch​ (1.1 KB) - added by psprint 3 years ago.

Change History

Changed 3 years ago by psprint

comment:1 Changed 3 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.27

Patch is applied with some modification.

Branch: 4207_tag_declaration
changeset:e64eb397e54c745e62a6eb695bb1ee3670d781c3

comment:2 Changed 3 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:3 Changed 3 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [94588d2da68a9c2f66c6156bd08fec58bfefda3e].

comment:4 Changed 3 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.