savannah: smbfs performance suffers badly if no username is specified in the URL

[ptsekov]

Original: ​http://savannah.gnu.org/bugs/?16216

Submitted by:	Pavel Tsekov <ptsekov>	Submitted on:	Wed 29 Mar 2006 03:07:47 PM UTC
Category:	VFS	Severity:	3 - Normal
Status:	None	Privacy:	Public
Assigned to:	None	Open/Closed:	Open
Release:	current (CVS or snapshot)	Operating System:	All

Original submission:

1) From the Left or Right menu select SMB Link

2) Type the hostname of a remote samba server

3) \\Password for \\xxx.xxx.xxx.xxx\IPC$ dialog appears. In the 
Username field type GUEST

4) Navigate to a share and press Enter. Notice how long it takes to 
load the listing

5) Go to a .tar.gz file and hit Enter -> MC will crash

This problem is caused by the fact that smbfs uses a pool of active 
connections which are uniquely identified by their hostname, 
username and sharename. When no user is specified in the url, but 
in the "Password for" dialog and this name is different from the 
current login name, smbfs thinks that we are trying to connect to 
the remote machine with the current login name. This confuses smbfs 
and it doesn't notice that there is a valid connection which can be 
reused - the result is that smbfs opens a new connection each time 
it needs to issue a command to the samba server.
	Pavel Tsekov <ptsekov>
Project Administrator

Comment 1 by Pavel Tsekov <ptsekov> at Thu 30 Mar 2006 09:10:24 AM UTC:

I am attaching a patch.

[andrew_b]

[6f676d06676cc5d271583754f15473af78a36ac4]