Ticket #4181 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Compile failure on OS X 10.9.5

Reported by: kroleg Owned by: andrew_b
Priority: major Milestone: 4.8.27
Component: mc-tty Version: 4.8.26
Keywords: Cc: kybl
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description 

tty-ncurses.c:556:5: error: unknown type name 'cchar_t'; did you mean 'wchar_t'?
    cchar_t *ctext;
    ^~~~~~~
    wchar_t
/usr/include/sys/_types/_wchar_t.h:33:26: note: 'wchar_t' declared here
typedef __darwin_wchar_t wchar_t;
                         ^
tty-ncurses.c:565:31: error: use of undeclared identifier 'cchar_t'; did you mean 'wchar_t'?
    ctext = g_malloc (sizeof (cchar_t) * (cols + 1));
                              ^
/usr/include/sys/_types/_wchar_t.h:33:26: note: 'wchar_t' declared here
typedef __darwin_wchar_t wchar_t;
                         ^
tty-ncurses.c:569:9: warning: implicit declaration of function 'mvin_wchnstr' is invalid in C99
      [-Wimplicit-function-declaration]
        mvin_wchnstr (y + row, x, ctext, cols);
        ^
tty-ncurses.c:573:13: warning: implicit declaration of function 'getcchar' is invalid in C99
      [-Wimplicit-function-declaration]
            getcchar (&ctext[col], wch, &attrs, &color_pair, NULL);
            ^
tty-ncurses.c:574:13: warning: implicit declaration of function 'setcchar' is invalid in C99
      [-Wimplicit-function-declaration]
            setcchar (&ctext[col], wch, attrs, color, NULL);
            ^
tty-ncurses.c:577:9: warning: implicit declaration of function 'mvadd_wchnstr' is invalid in C99
      [-Wimplicit-function-declaration]
        mvadd_wchnstr (y + row, x, ctext, cols);
        ^
9 warnings and 2 errors generated.
make[3]: *** [tty-ncurses.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
mc-4.8.26-x86_64-ncurses build error 
bash-4.4$

Attachments

mc-4.8.26-ncurses.patch​ (418 bytes) - added by andrew_b 3 years ago.

Change History

comment:1 Changed 3 years ago by andrew_b

  • Cc kybl added
  • Version changed from master to 4.8.26

Changed 3 years ago by andrew_b

comment:2 follow-up: ↓ 3 Changed 3 years ago by andrew_b

@kroleg, please try mc-4.8.26-ncurses.patch.

comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed 3 years ago by kroleg

Replying to andrew_b:

@kroleg, please try mc-4.8.26-ncurses.patch.

Building mc-4.8.26-ncurses completed successfully. Thank you.

comment:4 in reply to: ↑ 3 ; follow-up: ↓ 5 Changed 3 years ago by andrew_b

Replying to kroleg:

Building mc-4.8.26-ncurses completed successfully. Thank you.

Does it works correctly (I mean #4102)?

comment:5 in reply to: ↑ 4 Changed 3 years ago by kroleg

Replying to andrew_b:

Replying to kroleg:

Building mc-4.8.26-ncurses completed successfully. Thank you.

Does it works correctly (I mean #4102)?

Yes, shadows work great!
Beautifully )

comment:6 Changed 3 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.27

Branch: 4182_osx_ncurses_ftbfs.
changeset:ba62dd32add2767d6d13f9abb82f43304418740f

comment:7 Changed 3 years ago by andrew_b

  • Votes for changeset set to kroleg andrew_b
  • Branch state changed from on review to approved

comment:8 Changed 3 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from kroleg andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [25bc8a64d9d4ee1672d6319a26e5628d5cf1ac1a].

comment:9 Changed 3 years ago by andrew_b

  • Status changed from testing to closed

comment:10 follow-up: ↓ 11 Changed 3 years ago by kybl

Thanks for the patch! I don't have OS X so I did not have a chance to try it. Sorry for that :-)

comment:11 in reply to: ↑ 10 Changed 3 years ago by andrew_b

Replying to kybl:

Thanks for the patch! I don't have OS X

I don't have too.

so I did not have a chance to try it. Sorry for that :-)

I googled a ​email with useful info.

Note: See TracTickets for help on using tickets.