Ticket #4179 (closed task: fixed)

Opened 8 months ago

Last modified 6 weeks ago

Prepare for release mc-4.8.27

Reported by: zaytsev Owned by:
Priority: major Milestone: 4.8.27
Component: adm Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description


Attachments

mc-4179-fix-lto-type-mismatch-warning.patch (2.4 KB) - added by and 7 months ago.
mc-4179-hex_translate_to_regex.c-fix-maybe-uninitialize-warning.patch (1.3 KB) - added by and 7 months ago.
mc-4179-libcheck-fail-deprecated.patch (1.5 KB) - added by and 7 months ago.
mc-4179-libcheck-fail_unless-deprecated.patch (10.1 KB) - added by and 7 months ago.
mc-4179-chattr.c-fix-cast-qual-warning.patch (1.8 KB) - added by and 7 months ago.
mc-4179-extfs.c-fix-cast-qual-warning.patch (1.7 KB) - added by and 7 months ago.
mc-4179-filegui.c-fix-cast-qual-warning.patch (2.0 KB) - added by and 7 months ago.
mc-4179-group.c-fix-cast-qual-warning.patch (2.6 KB) - added by and 7 months ago.
mc-4179-input.c-fix-cast-qual-warning.patch (1.3 KB) - added by and 6 months ago.
mc-4179-internal.c-fix-cast-qual-warning.patch (2.4 KB) - added by and 6 months ago.
mc-4179-menu.c-fix-cast-qual-warning.patch (1.1 KB) - added by and 6 months ago.
mc-4179-panel.c-fix-cast-qual-warning.patch (1.1 KB) - added by and 6 months ago.
mc-4179-cid-background.c-fix-argument-cannot-be-negative.patch (1.9 KB) - added by and 4 months ago.
mc-4179-cid-editcmd.c-fix-dereference-before-null-check.patch (1.2 KB) - added by and 4 months ago.
mc-4179-editdraw.c-fix-deadcode.deadstores-warning.patch (1.6 KB) - added by and 4 months ago.
mc-4179-editsearch.c-fix-deadcode.deadstores-warning.patch (1.0 KB) - added by and 4 months ago.
mc-4179-file.c-fix-deadcode.deadstores-warning.patch (1.0 KB) - added by and 4 months ago.
mc-4179-syntax.c-fix-deadcode.deadstores-warning.patch (1.1 KB) - added by and 4 months ago.
mc-4179-cid-dir.c-fix-resource-leak.patch (763 bytes) - added by and 4 months ago.
mc-4179-cid-ext.c-fix-resource-leak.patch (811 bytes) - added by and 4 months ago.
mc-4179-cid-hotlist.c-fix-use-after-free.patch (1.3 KB) - added by and 4 months ago.
mc-4179-cid-serialize.c-fix-resource-leak.patch (666 bytes) - added by and 4 months ago.
mc-4179-cid-vfs_class.c-fix-double-free.patch (771 bytes) - added by and 4 months ago.

Change History

comment:1 Changed 8 months ago by andrew_b

Changed 7 months ago by and

Changed 7 months ago by and

Changed 7 months ago by and

comment:2 Changed 7 months ago by andrew_b

mc-4179-fix-lto-type-mismatch-warning.patch​: applied.
mc-4179-hex_translate_to_regex.c-fix-maybe-uninitialize-warning.patch​: applied.
mc-4179-libcheck-fail-deprecated.patch​: applied.
mc-4179-libcheck-fail_unless-deprecated.patch​: applied.

Thanks!

comment:3 Changed 7 months ago by andrew_b

  • Branch state changed from no branch to merged

Merged to master: [f223210dcdfdca0171c6c2e88eabb27aaef20ae0].

git log pretty=oneline 318981535..f223210dc

comment:4 Changed 7 months ago by andrew_b

  • Branch state changed from merged to no branch

Changed 7 months ago by and

Changed 7 months ago by and

Changed 7 months ago by and

Changed 7 months ago by and

comment:5 Changed 7 months ago by andrew_b

mc-4179-chattr.c-fix-cast-qual-warning.patch​: applied.
mc-4179-extfs.c-fix-cast-qual-warning.patch​​: applied.
mc-4179-filegui.c-fix-cast-qual-warning.patch​: applied.
mc-4179-group.c-fix-cast-qual-warning.patch​: applied.

Thanks!

Branch: 4179_cleanup
Initial changeset:b31642cdd0a527f40786cff491666f1ac8fba4e1

Last edited 4 months ago by andrew_b (previous) (diff)

Changed 6 months ago by and

Changed 6 months ago by and

Changed 6 months ago by and

Changed 6 months ago by and

comment:6 Changed 6 months ago by andrew_b

mc-4179-input.c-fix-cast-qual-warning.patch​,
mc-4179-internal.c-fix-cast-qual-warning.patch​,
mc-4179-menu.c-fix-cast-qual-warning.patch​,
mc-4179-panel.c-fix-cast-qual-warning.patch​ squashed to one commit.

comment:7 Changed 4 months ago by andrew_b

mc-4179-cid-background.c-fix-argument-cannot-be-negative.patch​

I think the following patch is more simple:

  • src/background.c

    diff --git a/src/background.c b/src/background.c
    index 584cd74ef..b5c64a5d0 100644
    a b background_attention (int fd, void *closure) 
    281281 
    282282    if (to_child_fd == -1) 
    283283        message (D_ERROR, background_process_error, "%s", _("Unknown error in child")); 
    284  
    285     /* Handle the call */ 
    286     if (type == Return_Integer) 
     284    else if (type == Return_Integer) 
    287285    { 
     286        /* Handle the call */ 
     287 
    288288        int result = 0; 
    289289 
    290290        if (have_ctx == 0) 

mc-4179-cid-editcmd.c-fix-dereference-before-null-check.patch

I think the test

   if (edit->search == NULL)

in edit_do_search() can be just removed or replaced with assert to catch such case (can it occurs?).

comment:8 Changed 4 months ago by and

yes, your approach is more nice and simple. :)

comment:9 Changed 4 months ago by andrew_b

mc-4179-file.c-fix-deadcode.deadstores-warning.patch

Probably something is incorrect in fix of #4027. Extra testing is required.

comment:10 Changed 4 months ago by andrew_b

mc-4179-cid-background.c-fix-argument-cannot-be-negative.patch​: done
mc-4179-cid-editcmd.c-fix-dereference-before-null-check.patch​: done
mc-4179-editdraw.c-fix-deadcode.deadstores-warning.patch​: done
mc-4179-editsearch.c-fix-deadcode.deadstores-warning.patch​: done
mc-4179-syntax.c-fix-deadcode.deadstores-warning.patch​: done

Changed 4 months ago by and

Changed 4 months ago by and

Changed 4 months ago by and

Changed 4 months ago by and

Changed 4 months ago by and

comment:11 Changed 4 months ago by andrew_b

mc-4179-cid-dir.c-fix-resource-leak.patch​: done
mc-4179-cid-ext.c-fix-resource-leak.patch​: done
mc-4179-cid-hotlist.c-fix-use-after-free.patch​: done
mc-4179-cid-serialize.c-fix-resource-leak.patch​: done
mc-4179-cid-vfs_class.c-fix-double-free.patch​: first free is the bug, not second one.

comment:12 Changed 3 months ago by andrew_b

  • Votes for changeset set to committed-master
  • Branch state changed from no branch to merged

Merged to master: [a81f1ca19047da81afde5f0f4d7ba7271d8c504c]

git log --pretty=oneline 77545fbb6..a81f1ca19

comment:13 Changed 6 weeks ago by zaytsev

  • Status changed from new to closed
  • Resolution set to fixed

prepare repository for release
download PO-translations from Transifex.net
store translations in git repo
download the hint translations from Transifex.net
store translations in git repo

done

create new NEWS wiki page for next version

NEWS-4.8.28

add content of current NEWS wiki page to the doc/NEWS file
new version in Trac
new milestone in Trac
create new tag in git
create tar.(bz2|xz) package files
make checksums for archives

done

upload source packages and checksums to the special upload area

skipped

developers should download tarballs, verify checksums, compile and install locally

done

upload source packages and checksums
run command
update Wiki start page
write an announcement

done

create new ticket

#4270

close ticket for release
close current milestone

done

Note: See TracTickets for help on using tickets.