Ticket #4178 (closed defect: wontfix)
[patch] Commit make indent changes
Reported by: | psprint | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | mc-core | Version: | master |
Keywords: | indent | Cc: | |
Blocked By: | Blocking: | ||
Branch state: | no branch | Votes for changeset: |
Description
Hi,
after running make indent there are files that are already committed that are updated. The patch contains the changes so that they wouldn't come up again after running the make command.
Attachments
Change History
comment:1 Changed 4 years ago by andrew_b
My
$ indent --version GNU indent: 2.2.11
doesn't change tests/lib/strutil/filevercmp.c.
comment:2 Changed 4 years ago by psprint
I confirm that 2.2.11 doesn't change the file (version 2.2.9 was). However, trying the newest version 2.2.12 yields many changes such as;
-vfs_parse_ls_lga (const char *p, struct stat * s, char **filename, ch - size_t * num_spaces) +vfs_parse_ls_lga (const char *p, struct stat *s, char **filename, cha + size_t *num_spaces)
-} advanced_chown_but[BUTTONS] = -{ +} advanced_chown_but[BUTTONS] = {
-handle_path (const char *path, struct stat * buf1, gboolean * link_to +handle_path (const char *path, struct stat *buf1, gboolean * link_to_
FileProgressStatus compute_dir_size (const vfs_path_t * dirname_vpath, dirsize - size_t * ret_dir_count, size_t * ret_mark + size_t *ret_dir_count, size_t *ret_marked uintmax_t * ret_total, gboolean follow_sy
-tar_read_header (struct vfs_class *me, struct vfs_s_super *archive, int tard, size_t * h_size) +tar_read_header (struct vfs_class *me, struct vfs_s_super *archive, int tard, size_t *h_size)
-cli_message_text (struct cli_state * cli, char *msg, int len, int grp) +cli_message_text (struct cli_state *cli, char *msg, int len, int grp)
etc.
It seems a bug to the earlier indent versions, to format the asterisks sometimes with a following space… So it would be reasonable to switch to the latest indent 2.2.12. Just noting. For now one can stick with 2.2.11.
Note: See
TracTickets for help on using
tickets.