Add option to complete words from all open files

[psprint]

Hi,
I submit a patch that adds a new option to mcedit: editor_wordcompletion_collect_all_files which, when enabled, works as follows:

– normally when editing a file A and requesting a completion one gets candidates only from the same file A,
– other open files aren't searched,
– this option changes that – it makes the completion engine to provide candidates from all currently open files.

I think that it's a more usable scenario. All other editors like Vim complete in this way. I'm editing quite much in mcedit and have been hitting the *same buffer* limitation often so that I've decided to submit a patch. I've made the option enabled by default.

[andrew_b]

If you offer your patches for some project, please stick to the coding style of that project.

[psprint]

Ok, but what's wrong with the style in the patch?

[andrew_b]

https://midnight-commander.org/wiki/Hacking

[psprint]

I don't contribute often and I forgot about such style rules, getting my hands wet... I'll send an updated patch later today.

[psprint]

I've fixed the indentation and coding style. The option name is now editor_wordcompletion_collect_other_files (it was: …_all_files). It is by default set to true. The other option, editor_wordcompletion_collect_entire_file, is also default true now. I think that the defaults should be the ones that are most useful ones, and for the completion that's to complete from all files, period. So that the completion is like in the other, competing editors like vim or emacs.

PS. The completion list is now also made unique, so that the multiple occurrences (in multiple files) of a symbol are filtered out.

[psprint]

complete from all open buffers by default

[andrew_b]

Replying to psprint:

I've fixed the indentation and coding style. The option name is now editor_wordcompletion_collect_other_files (it was: …_all_files). It is by default set to true.

New option isn't documented in man page.

The other option, editor_wordcompletion_collect_entire_file, is also default true now.

This is independent change. Please move it to separate patch (no need in creation of new ticket for that).

[psprint]

Here's a patch that makes the editor_wordcompletion_entire_file option enabled by default.

[psprint]

no change of other options

[psprint]

includes manpage documentation on the new option

[andrew_b]

Branch: 4160_complete_all_files
Initial changeset:4779b400a726f885b841a6b31769ed6490890081

Please test.

[andrew_b]

Merged to master: [79628270a75e335a85c0c31c9273c4fad6512492].

git log --pretty=oneline a34525c5f..79628270a

[psprint]

Thanks. BTW, nice refactoring with GQueue.

[psprint]

I've noticed that the order of the completion matches is reversed – i.e.: the ones that are located earlier in any buffer are displayed later in the completion listbox. (​explanation, it uses the patch to list all functions in the file keeping the order). I wonder if this is done by accident, because IMO it doesn't make sense to reverse the order like that.

[andrew_b]

Replying to psprint:

I've noticed that the order of the completion matches is reversed

That was done in #1486. I tried to keep that solution for current file. Order of completions from other files is unimportant.