Ticket #4154 (closed defect: fixed)
Restore RAR 6.0 compatibility
| Reported by: | birdie | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.8.27 |
| Component: | mc-vfs | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
Now that RAR 6.0 has been released this code breaks and uses the RAR 4 handler for RAR 6 archives. Adjust the comparison to use the RAR 5 handler for all future releases by default now that rar/unrar 4.0 is getting out of use.
Change History
comment:2 follow-up: ↓ 3 Changed 4 years ago by andrew_b
We don't use pull requests. Please remember that.
comment:3 in reply to: ↑ 2 ; follow-up: ↓ 5 Changed 4 years ago by birdie
Replying to andrew_b:
We don't use pull requests. Please remember that.
Please merge however you want. :-) The fix is provided.
comment:4 Changed 4 years ago by birdie
Sometimes it all looks a little bit f---ed up. An issue is reported, a fix is provided and instead of merging it and maybe, God forbid, thanking the reporter, you say "We don't use pull requests". This surely looks a little bit like "F--- off, we're OK with our bugs and our snail's pace fixes".
comment:6 Changed 4 years ago by zaytsev
This surely looks a little bit like "F--- off, we're OK with our bugs and our snail's pace fixes".
It might indeed look this way from the your point of view.
From the maintainers point of view, it looks quite different though:
- Someone comes around, and doesn't give a shit about what processes the maintainers use. (Okay, fair enough - at least you were so nice as to open a ticket to point to your pull request - most don't even care to invest that much effort.)
- You quickly fix your own problem with smallest possible fix, of course, without any visible tests (there are VFS tests, which you should have extended!) and not even background information of how you tested it and what the change is supposed to do / why it is implemented this way.
- Now apparently we have to do 20x more work than you invested, and URGENTLY - because if we just merge, release without doing the work and it doesn't work for others, we are going to get a shitload of aggressive reports "WHY DID YOU BREAK MY RAR!!!11", which always happen when we miss some mistake in user patch.
- If we don't do it URGENTLY, then you come again and went your unwarranted frustration, thanks for that. In fact, whatever we do, we lose.
So actually, to me it rather sounds like "F--- off maintainers, you are stupid assholes and I'm the king on the white horse".
comment:7 Changed 4 years ago by birdie
- Priority changed from major to trivial
- Version master deleted
- Milestone 4.8.26 deleted
I get it, the fix is so effing complicated it requires unit tests and sh*t even though you were totally OK with not having any unit tests for this code in the past. So, not only I have to report a bug, I also have to write unit tests, learn your workflow and send you an appropriate patch for four effing modified characters. I will do my best not to bother you any longer with stupid patches and stupid bug reports. You definitely need neither.
Please close this bug report as invalid.
comment:8 Changed 4 years ago by andrew_b
- Status changed from new to accepted
- Priority changed from trivial to major
- Version set to master
- Branch state changed from no branch to on review
- Milestone set to 4.8.27
- Owner set to andrew_b
Branch: 4154_rar6
changeset:84b435fa39286f25cb2d3a85db94b023a1d89092
comment:9 Changed 4 years ago by zaytsev
- Votes for changeset set to zaytsev
- Branch state changed from on review to approved
Thanks Andrew!
P.S. What a drama...
comment:10 Changed 4 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from zaytsev to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [b0ed56e4e88c2ae5475013ba4bf1dfbad5314e82].
It's a very simple fix, please merge ASAP.