Ticket #4131 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

warning: Deprecated pre-processor symbol, replace with G_UNICODE_COMBINING_MARK

Reported by: angel_il Owned by: andrew_b
Priority: major Milestone: 4.8.26
Component: mc-core Version: master
Keywords: deprecated symbol Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description (last modified by andrew_b) (diff) 

Making all in strutil
make[3]: вход в каталог «/home/holmes/buildroot/mc/lib/strutil»
  CC       strutilutf8.lo
strutilutf8.c: In function ‘str_unichar_iscombiningmark’:
strutilutf8.c:73:13: warning: Deprecated pre-processor symbol, replace with 
   73 |     return (type == G_UNICODE_COMBINING_MARK)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~               
  CCLD     libmcstrutil.la

Attachments

str_unichar_iscombiningmark.patch​ (850 bytes) - added by angel_il 4 years ago.
fixup for G_UNICODE_COMBINING_MARK has been deprecated since version 2.30 and should not be used in newly-written code. Use G_UNICODE_SPACING_MARK.
0001-Ticket-4131-use-G_UNICODE_SPACING_MARK-instead-of-G_.patch​ (2.3 KB) - added by andrew_b 4 years ago.

Change History

Changed 4 years ago by angel_il

fixup for G_UNICODE_COMBINING_MARK has been deprecated since version 2.30 and should not be used in newly-written code. Use G_UNICODE_SPACING_MARK.

comment:1 Changed 4 years ago by andrew_b

  • Description modified (diff)

MC requires glib >= 2.30. Therefore we can just get rid of G_UNICODE_COMBINING_MARK usage.

comment:2 Changed 4 years ago by angel_il

on system with glib 2.64 i have WARNING on making 'strutil' it's OK?

$ pkg-config --modversion glib-2.0
2.64.3

Making all in strutil
make[3]: вход в каталог «/home/holmes/buildroot/mc/lib/strutil»

CC strutilutf8.lo

strutilutf8.c: In function ‘str_unichar_iscombiningmark’:
strutilutf8.c:73:13: warning: Deprecated pre-processor symbol, replace with

73 | return (type == G_UNICODE_COMBINING_MARK)

|

CCLD libmcstrutil.la

Version 0, edited 4 years ago by angel_il (next)

Changed 4 years ago by andrew_b

comment:3 Changed 4 years ago by andrew_b

angel_il, try 0001-Ticket-4131-use-G_UNICODE_SPACING_MARK-instead-of-G_.patch​.

comment:4 Changed 4 years ago by angel_il

thnx, looks good for me.
no more warnings.

comment:5 Changed 4 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.26

comment:6 Changed 4 years ago by andrew_b

  • Votes for changeset set to andrew_b angel_il
  • Branch state changed from no branch to approved

Committed to master: [5bf714b008210c88dfa9cde6b921ebdc0e562664].

comment:7 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:8 Changed 4 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.