Ticket #410 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

certain binary treated-as-roff files cause viewer hangup

Reported by: slyfox Owned by: slyfox
Priority: major Milestone: 4.7.0-pre1
Component: mc-core Version:
Keywords: committed-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by slyfox) (diff)

Steps to reproduce:

  1. download attachment
  2. unbzip it
  3. open by F3
  4. scroll down until it hangs

Commited to master as a single changeset:
changeset:40438bfd0f724e15706055409e253380b55791e8

Attachments

mhdd32ver4.6.bz2 (456.5 KB) - added by slyfox 10 years ago.
0001-viewer-Ticket-410-certain-binary-treated-as-roff.patch (1.5 KB) - added by slyfox 10 years ago.
rfc patch. may subtly break something

Change History

Changed 10 years ago by slyfox

comment:1 Changed 10 years ago by slyfox

  • Version 4.6.2 deleted

comment:2 Changed 10 years ago by angel_il

  • Milestone changed from 4.7 to 4.7.0-pre1

Changed 10 years ago by slyfox

rfc patch. may subtly break something

comment:3 Changed 10 years ago by slyfox

  • Keywords review added

Slightly modified fix is available as a single commit: changeset:40438bfd0f724e15706055409e253380b55791e8

In addinion to proposed patch it has slightly sanitized error descriptor handling.

Please review.

comment:4 Changed 10 years ago by slyfox

  • Owner set to slyfox
  • Status changed from new to assigned

comment:5 Changed 10 years ago by angel_il

  • Keywords vote-angel_il added

comment:6 Changed 10 years ago by slavazanko

  • Keywords vote-slavazanko approved added; review removed

comment:7 Changed 10 years ago by slyfox

  • Status changed from assigned to testing
  • Keywords committed-master added; vote-angel_il vote-slavazanko approved removed
  • Resolution set to fixed
  • Description modified (diff)

Commited to master as a single changeset:
changeset:40438bfd0f724e15706055409e253380b55791e8

comment:8 Changed 10 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.