Ticket #4039 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Bool vs. int inconsistency in config files

Reported by: egmont Owned by:
Priority: minor Milestone: 4.8.24
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset: committed-master

Description

Up until 3 years ago (commit c4550374b2c and a few followup ones) mc used to store config file entries like

shell_patterns=1

but then it was changed to

shell_patterns=true

The switch was incomplete, the "[Layout]" section still contains integers, e.g.:

menubar_visible=1

resulting in an inconsistent use of booleans in the config file.

([HotlistConfig] -> expanded_view_of_groups is also an integer instead of boolean, but see #4038 for that.)

Change History

comment:1 Changed 4 years ago by andrew_b

Done in the 3997_cleanup branch.

comment:2 Changed 4 years ago by andrew_b

  • Blocked By 3997 added

comment:3 Changed 4 years ago by andrew_b

  • Votes for changeset set to committed-master
  • Milestone changed from Future Releases to 4.8.24

Fixed as [b2141c0ff02b80d2ce5123dd4e60d40f77ccca5f].

comment:4 Changed 4 years ago by andrew_b

  • Blocked By 3997 removed

comment:5 Changed 4 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to fixed

comment:6 Changed 4 years ago by andrew_b

Small fix is [9ede2fa80b7953290ced77dbca8da5c16aa75a7e].

Note: See TracTickets for help on using tickets.