Ticket #4 (closed defect: fixed)

Opened 9 years ago

Last modified 4 years ago

savannah: Incorrect sorting of localized filenames

Reported by: slavazanko Owned by:
Priority: major Milestone: 4.7
Component: mc-core Version:
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description (last modified by ossi) (diff)

Original: http://savannah.gnu.org/bugs/?8158

Submitted by:NoneSubmitted on:Tue 16 Mar 2004 02:07:53 AM UTC
Category:Screen outputSeverity:3 - Normal
Status:NonePrivacy:Public
Assigned to:NoneOpen/Closed:Open
Release:4.6.0Operating System:GNU/Linux

Original submission:

I have a koi8-r locale and some files with russian names. When 
sorting configured as case sensitive, I can see a new russian 
alphabet at the panels :)

I look in source code and found an error - the "strcmp" function 
used for sorting all names, but it's doesn't know about any locale. 
So it should be replaced by something else. For example, "wcscmp".

Here is the patch to correct this problem. It's some big, but I 
think, it's will be work with any locales.

Attachments

mc-4.6.0-sort-fix.patch (1.5 KB) - added by slavazanko 9 years ago.

Change History

Changed 9 years ago by slavazanko

comment:1 follow-up: ↓ 4 Changed 9 years ago by guanx

  • Keywords rework added

Tested with mc-4.6.2 + utf8 patch in zh_CN.UTF-8 locale. Does not work (should sort Chinese like strcoll, but actually in random order).

comment:2 Changed 9 years ago by styx

  • Milestone set to 4.7

comment:3 Changed 9 years ago by angel_il

  • Status changed from new to closed
  • Resolution set to fixed

in master not actually

comment:4 in reply to: ↑ 1 Changed 9 years ago by angel_il

Replying to guanx:

zh_CN.UTF-8 locale. Does not work (should sort Chinese).

try in master, i can't test in Chinese i don't speak/read in chinese.

comment:5 Changed 4 years ago by ossi

  • Description modified (diff)
  • Branch state set to no branch

comment:6 Changed 4 years ago by andrew_b

  • Keywords rework removed
Note: See TracTickets for help on using tickets.