iso9660 does not report listing errors

[slyfox]

This bug is a few variations of ​https://bugs.gentoo.org/533214.
I believe they all stem from the same underlying cause: iso9660 does not report listing errors.

Variation 1:

Steps to reproduce:

• create empty .iso file (touch foo.iso)
• run 'mc' and press enter on empty .iso

Expected result: some error about invalid file format (sililar to what F3 view would yield)
Actual result: mc elters a file as if it would be empty valid file

Variation 2:
Steps to reproduce:

• pick valid .iso file
• deinstall all helper tools that handle .sio (isoinfo, xorriso, etc.)
• run 'mc' and press enter on empty .iso

Expected result: some error about invalid file format (sililar to what F3 view would yield)
Actual result: mc enters a file as if it would be empty valid file

Variation 2 is especially confusing for users as it does not hint them that they should install a tool to get it working. They just observe silently broken behaviour.

$ LANG=C mc --version
GNU Midnight Commander 4.8.22
Built with GLib 2.58.3
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ext2undelfs, ftpfs, sftpfs, fish, smbfs
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

[andrew_b]

src/vfs/extfs/helpers/iso9660.in

@@ -133 +133 @@
       *)     MYCAT="cat";;
     esac
 
-    $ISOINFO -l -i "$1" 2>/dev/null | @AWK@ -v SEMICOLON=$SEMICOLON '
+    $ISOINFO -l -i "$1" | @AWK@ -v SEMICOLON=$SEMICOLON '
 BEGIN {
   dir="";
   # Pattern to match 8 first fields.

[andrew_b]

Branch: 3993_iso9660_error_report
Initial changeset:1ea6788c12b8f9a1151972d354bfc90c73e4b6e3

[andrew_b]

Merged to master: [27fe8f39a3e79965f3f16029ec7a25a4840d645d].

git log --pretty=oneline 3a1f3d7ff..27fe8f39a