Move over ssh shell will destory files when target FS full

[BruXy]

Happened in mc 4.8.15-2 in Ubuntu 16.04.5 LTS.

1. I was moving huge amount of files over ssh shell (Shell link).
2. The target file system became full.
3. When 2. happened files were still copied but appeared on target with zero sizes.
4. Files were deleted on the source.

I would expect an error message and not deleting source files.

[BruXy]

mc --version
GNU Midnight Commander 4.8.15
Built with GLib 2.47.3
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ext2undelfs, ftpfs, sftpfs, fish
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

[andvaranaut]

Hi, please check #3963, which seems to be another facet of the same bug, and which, as I have confirmed, is still present in the current stable version (4.8.22).

[BruXy]

Yes, it may have the same root cause as #3963 and this ticket is duplicating it.

[metux]

Sure that #77 is really necessary for that ?

I believe it should just check whether writing to remote side finished properly.
(maybe do a stat afterwards), before unlink'ing the original.

--mtx