Ticket #390 (closed task: fixed)

Opened 10 years ago

Last modified 9 years ago

remove own 'libpopt' stuff

Reported by: slavazanko Owned by: slavazanko
Priority: major Milestone: 4.7.0-pre3
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

We really don't need for all libpopt features. As fact, simple POSIX getopt() is enough. But if we have glib - we must use glib for unification.

Change History

comment:1 Changed 10 years ago by angel_il

  • severity set to no branch
  • Milestone changed from 4.7 to 4.7.0-pre2

comment:2 Changed 10 years ago by iNode

  • Status changed from new to accepted
  • Owner set to iNode

comment:3 Changed 10 years ago by angel_il

  • Milestone changed from 4.7.0-pre2 to 4.7.0-pre3

comment:4 Changed 10 years ago by slavazanko

  • Owner changed from iNode to slavazanko

comment:5 Changed 10 years ago by slavazanko

  • severity changed from no branch to on review

Created branch 390_remove_libpopt (parent: master)

Initial changeset:96146a6bff094fd673b4d7445af35d373ca574a7

review, please.

comment:6 Changed 10 years ago by slavazanko

  • Blocking 1497 added

comment:7 Changed 10 years ago by slavazanko

changeset:4978f370ab23f483570968b45473caff1d5ab86f

  • Descriptions of options now translated.
  • Fixed help output in non-UTF system codepages.

Review.

comment:8 follow-up: ↓ 9 Changed 10 years ago by andrew_b

  • Votes for changeset set to andrew_b

That's great! My vote here.

comment:9 in reply to: ↑ 8 Changed 10 years ago by angel_il

Replying to andrew_b:

That's great! My vote here.

/home/projects/mc/src/args.c:412: undefined reference to `g_option_context_set_translation_domain'
args.o(.text+0x13e):/home/projects/mc/src/args.c:341: undefined reference to `g_option_context_set_description'
args.o(.text+0x173):/home/projects/mc/src/args.c:344: undefined reference to `g_option_context_set_summary'
args.o(.text+0x34d):/home/projects/mc/src/args.c:445: undefined reference to `g_option_context_get_help'

it's really great :)

comment:10 Changed 10 years ago by andrew_b

Now required GLib >= 2.14. configure.ac must be fixed.

comment:11 Changed 10 years ago by iNode

  • Votes for changeset andrew_b deleted
  • severity changed from on review to on rework

main.c:101 #include "popt.h" should be removed, at least for correct building.

comment:12 Changed 10 years ago by slavazanko

  • severity changed from on rework to on review

main.c:101 #include "popt.h" should be removed, at least for correct building.

Fixed.

Branch rebased into one changeset:d791bfa4c2d193505e15de660cb1f6fe37257724

review again

comment:13 Changed 10 years ago by angel_il

  • Votes for changeset set to angel_il

comment:14 Changed 10 years ago by andrew_b

  • Votes for changeset changed from angel_il to angel_il andrew_b
  • severity changed from on review to approved

comment:15 Changed 10 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il andrew_b to commited-master
  • Resolution set to fixed
  • Blocking 1497 removed
  • severity changed from approved to merged

comment:16 Changed 10 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.