Ticket #3876 (closed task: fixed)

Opened 7 months ago

Last modified 3 weeks ago

Prepare for release mc-4.8.21

Reported by: zaytsev Owned by: zaytsev
Priority: major Milestone: 4.8.21
Component: adm Version: master
Keywords: Cc: egmont
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description


Change History

comment:1 Changed 7 months ago by egmont

  • Cc egmont added

comment:2 Changed 7 months ago by andrew_b

  • Version set to master
Last edited 6 months ago by andrew_b (previous) (diff)

comment:3 follow-up: ↓ 4 Changed 6 months ago by and

How do deal with deprecated makedev(),major(),minor() pull from sys/types.h since glibc 2.25 ?

https://sourceware.org/ml/libc-alpha/2017-02/msg00079.html

parse_ls_vga.c:791:13: error: In the GNU C Library, "makedev" is defined
 by <sys/sysmacros.h>. For historical compatibility, it is
 currently defined by <sys/types.h> as well, but we plan to
 remove this soon. To use "makedev", include <sys/sysmacros.h>
 directly. If you did not intend to use a system-defined macro
 "makedev", you should undefine it after including <sys/types.h>. [-Werror]
         s->st_rdev = makedev (maj, min);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~                                                                                                                                                                                                                                                                                                                                                  
In file included from /usr/include/sys/types.h:226:0,
                 from /usr/include/stdlib.h:291,
                 from parse_ls_vga.c:40:}}}

comment:4 in reply to: ↑ 3 ; follow-up: ↓ 5 Changed 6 months ago by egmont

Replying to and:

How do deal with deprecated makedev(),major(),minor() pull from sys/types.h since glibc 2.25 ?

This problem was already raised in #3780 and #3857. No resolution yet I'm afraid. Perhaps autoconf needs to be upgraded to a git version on every system where mc's ./autogen.sh is run (that is, developers' and tarball creating machines).

comment:5 in reply to: ↑ 4 Changed 6 months ago by and

Replying to egmont:

Replying to and:

How do deal with deprecated makedev(),major(),minor() pull from sys/types.h since glibc 2.25 ?

This problem was already raised in #3780 and #3857. No resolution yet I'm afraid. Perhaps autoconf needs to be upgraded to a git version on every system where mc's ./autogen.sh is run (that is, developers' and tarball creating machines).

Ahh thanks, I will take #3857 for further discussion regarding <sys/types.h> warning.

comment:6 Changed 6 months ago by andrew_b

mc-3876-panel.c-Cleanup-potential-null-pointer-dereference-warning.patch​: applied.

mc-3876-dir.c-Cleanup-potential-null-pointer-dereference-warning.patch: I think this is overcheck. vpath_str == NULL is the result of vpath == NULL. If vpath == NULL, then mc_opendir() returns NULL, and line 653 is not reached.

mc-3876-edit.c-Cleanup-implicit-fallthrough-warnings.patch​:
mc-3876-editwidget.c-Cleanup-implicit-fallthrough-warnings.patch:
mc-3876-info.c-Cleanup-implicit-fallthrough-warnings.patch: applied and combined into single commit.

mc-3876-utilunix.c-Cleanup-implicit-fallthrough-warning.patch​:applied.

mc-3876-edit.c-Cleanup-unreachable-code-return-warning.patch​: applied.

Thanks!

comment:7 Changed 5 months ago by andrew_b

At this moment, 3876_cleanup has 35 commits. I thing this is time to make the first merge of this branch to master.

3876_cleanup rebased to current master.
Initial changeset:98f6c26304d3006e4ed4148eb810562a4e97d880.
Please review.

Last edited 5 months ago by andrew_b (previous) (diff)

comment:8 Changed 5 months ago by andrew_b

Merged to master: [c9ca0cc01bd627c19626083b88a5a3dd0642c6db].

git log --pretty=oneline e4d9a81..c9ca0cc

comment:9 Changed 4 weeks ago by zaytsev

prepare repository for release

done

download PO-translations from Transifex.net

done

store translations in git repo

done

download the hint translations from Transifex.net

done

store translations in git repo

done

create new NEWS wiki page for next version

NEWS-4.8.22

add content of current NEWS wiki page to the doc/NEWS file in git repo

done

comment:10 Changed 3 weeks ago by zaytsev

  • Owner set to zaytsev
  • Status changed from new to accepted
  • Branch state changed from no branch to on review

create new tag in git

done

new version in Trac

done

new milestone in Trac

done

create tar.(bz2|xz) package files

done

make checksums for archives

done

upload source packages and checksums to the special upload area

https://www.midnight-commander.org/nopaste/tarball/

developers should download tarballs, verify checksums, compile and install locally; if everything is ok, then developers vote for the ticket

comment:11 Changed 3 weeks ago by zaytsev

  • Votes for changeset set to zaytsev

comment:12 Changed 3 weeks ago by andrew_b

  • Votes for changeset changed from zaytsev to zaytsev andrew_b

comment:13 Changed 3 weeks ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset changed from zaytsev andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from on review to merged

upload source packages and checksums

done

run command

done

update Wiki start page with latest release number

done

write an announcement

done

create new ticket (type=task, component=adm) for the next release

done; #3915

close ticket for release

done

close current milestone

done

comment:14 Changed 3 weeks ago by zaytsev

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.