Ticket #3829 (closed enhancement: fixed)
Case-insensitive patterns in Syntax file
| Reported by: | andrew_b | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.8.20 |
| Component: | mcedit | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
Like mc.ext (#2250), Syntax should support case-insensitive file name patterns.
file/i ..\*\\.php[0-9]?$ PHP\sProgram include php.syntax
instead of
file ..\*\\.(php|PHP)[0-9]?$ PHP\sProgram include php.syntax
Change History
comment:2 Changed 7 years ago by andrew_b
Fortunately, PCRE supports case insensitive natively: (?!:...). So we can keep the C source code untouched and modify only Syntax.in file.
file ..\*\\.(php|PHP)[0-9]?$ PHP\sProgram include php.syntax
can be replaced with
file ..\*\\.(?i:php)[0-9]?$ PHP\sProgram include php.syntax
comment:4 Changed 7 years ago by andrew_b
- Status changed from new to accepted
- Owner set to andrew_b
- Branch state changed from no branch to on review
- Milestone changed from Future Releases to 4.8.20
Branch: 3829_syntax_case_insense
changeset:3aabbf2bd55f544fa7b81855d40787e0d2c19b6e
comment:5 Changed 7 years ago by zaytsev
I left some comments, but the only important one I think is the missing i for Haskell.
Also, it's "simplify case insensitive patterns."
comment:7 Changed 7 years ago by zaytsev
- Votes for changeset set to zaytsev
- Branch state changed from on review to approved
comment:8 Changed 7 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from zaytsev to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [b88e72e20f3a323227c96dfcae2a07d848b0a759].
git log --pretty=oneline bc961db..b88e72e
Note: See
TracTickets for help on using
tickets.
I think that's an excellent idea, the current situation is very annoying.