Ticket #3828 (closed enhancement: fixed)

Opened 7 years ago

Last modified 7 years ago

syntax highlighting for apache hive

Reported by: mlorek Owned by: zaytsev
Priority: minor Milestone: 4.8.20
Component: mcedit Version: master
Keywords: hive hql syntax Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset:

Description

Hi,

would it be possible to add syntax highlighting for apache hive scripts?

I have already prepared relevant files which can be found here:

​https://github.com/mlorek/mc/tree/hive_syntax

Change History

comment:1 follow-up: ↓ 2 Changed 7 years ago by andrew_b 

file ..\*\\.(hql|HQL)$ SQL\sProgram
include hive.syntax

Is it really SQL Program?

comment:2 in reply to: ↑ 1 Changed 7 years ago by mlorek

Replying to andrew_b:

file ..\*\\.(hql|HQL)$ SQL\sProgram
include hive.syntax

Is it really SQL Program?

well, it is a text script executed against Hive.
and hql is a dialect of sql.

comment:3 follow-ups: ↓ 4 ↓ 5 Changed 7 years ago by zaytsev

Andrew, OK to commit if SQL -> HiveQL?

Only I'm a bit bothered by commented out operators. Why?

comment:4 in reply to: ↑ 3 Changed 7 years ago by mlorek

Replying to zaytsev:

Andrew, OK to commit if SQL -> HiveQL?

Only I'm a bit bothered by commented out operators. Why?

This was work in progress and I did not know you guys use tickets.
I cleaned that section up a bit and pushed another version.

comment:5 in reply to: ↑ 3 Changed 7 years ago by andrew_b

Replying to zaytsev:

Andrew, OK to commit if SQL -> HiveQL?

OK.

comment:6 Changed 7 years ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev
  • Milestone changed from Future Releases to 4.8.20

comment:7 follow-up: ↓ 8 Changed 7 years ago by zaytsev

Branch: 3828_hive_syntax
Initial changeset:bb7be7

I still see some commented out stuff. Is this finished now? If not, please add a final commit to your branch and I will rebase.

comment:8 in reply to: ↑ 7 Changed 7 years ago by mlorek

Replying to zaytsev:

Branch: 3828_hive_syntax
Initial changeset:bb7be7

I still see some commented out stuff. Is this finished now? If not, please add a final commit to your branch and I will rebase.

It is finished now. All changes are part of the following branch:

​https://github.com/mlorek/mc/tree/hive_syntax

comment:9 Changed 7 years ago by zaytsev

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Branch state changed from no branch to merged

comment:10 Changed 7 years ago by zaytsev

  • Status changed from testing to closed

comment:11 Changed 7 years ago by andrew_b

Merged to master: [bc961db6322006b3994d3ac0842e0645a1bdf4d1].

comment:12 Changed 7 years ago by zaytsev

Sorry, forgot about it, thank you!

Note: See TracTickets for help on using tickets.