About colors schemes (skins)

[slavazanko]

This just my thinks. We need to make simple work with color schemas in mc.
All following examples (commands out) just for simple understanding, not real :)
For example:

$ ls /usr/share/mc/skins
standart.ini b&w.ini dark.ini

in ~/.mc/ini file:

[Midnight Commander]
...
skin=standart.ini
...

But user may customize color scheme:

[Midnight Commander]
...
skin=~/.mc/skin/my_own_skin.ini
...

• if basename(skin) == skin, then file will be get from /usr/share/mc/skins directory.

Example of skin-file:

[skin]
     name=Standart skin
[core]
    _default_=lightgray;blue
    normal=;
    selected=black;cyan
    marked=yellow;blue
    ...
[files]
    coredump=yellow;red
    temp=gray;
    archive=brightmagenta;
    source=cyan;
    media=green;
    graph=brightcyan;
    database=brightred;
    ...
[viewer]
    ...
[editor]
    normal=lightgray;blue
    bold=yellow;blue
    marked=black;cyan
    whitespace=brightblue;blue
    ...

• Parameter '_default_' may be present in any section and MUST be present in [core] section;
• Value of '_default_' parameter in [core] section MUST contain definition of two colors: foreground and background. In other sections value of this parameter MAY contain definition of two colors;
• If parameter '_default_' is absent in current section, then this parameter will be taken from [core] section;
• If some color in color pair don't specified, then this color will be taken from '_default_' parameter in current section;
• section name '[skin]' must be reserved for internal usage. All other section names will free for use (relative to source code).

Is this good idea?

[slavazanko]

Created branch 380_skins (parent: master)

initial changeset:1b903937a0b0664cb68985983a5561397b2488f8

for full changes view, run:

git diff 1b903937a0b0664cb68985983a5561397b2488f8^..f351b90836c97664817eb9b1738614db4e1607c0

Review, please.

[slavazanko]

(In #1622) well... PCRE_CFLAGS already in Makefile.am.

Reason of unsucessfull build is a #1608

But in #380 now we have lot of changes (as fact, #380 ready now for review, bay be some little bugs present in this branch:) ). In #380 bug from #1608 now fixed (and bug from this ticket fixed too). But if we will fix this ticket (and ticket:1608) may be some bugs added into #380 after rebasing of branch.

Just wait for merge #380 into master, please :).

[slavazanko]

Added some new commits into branch.
See

git diff 1b903937a0b0664cb68985983a5561397b2488f8^..61b01f10ef325e716a4b26ae20fe4d0f9dc5880b

for full list of changes.

Review, please.

[slavazanko]

merge changeset:b5c238655129122107400fd9e7c2be8645ccad7c

[andrew_b]

Two issues.

1. In BW mode (mc -b), the selected menu item color is the same as common menu entry color. Thus, selected item is not visually selected.

2. Locale is KOI8-R. MC is built with S-Lang library. If run mc as 'LC_ALL=C mc' then pseudo-graphics symbols are not displayed correctly. If MC is built with NCurses, everything is fine.

[andrew_b]

Created 380_bw_colors_and_frames branch. Parent branch: master.

Replying to andrew_b:

1. In BW mode (mc -b), the selected menu item color is the same as common menu entry color. Thus, selected item is not visually selected.

This issue is fixed, I hope. :-)
changeset:c54b26f0d8615dd3ab4463f1abb7c262e6ad97a6
changeset:fb96de25688abe00e608a6addce7fcf7c6baa1bc
changeset:24bd9b9da1b5c7ee3686e9e5e740e2e62a0f52ec
changeset:1d5ab3bdccec5d3edf446d7e3dfd656bc148efb8

[slavazanko]

1. In BW mode (mc -b), the selected menu item color is the same as common menu entry color. Thus, selected item is not visually selected.

As fact, already fixed into branch.

2. Locale is KOI8-R. MC is built with S-Lang library. If run mc as 'LC_ALL=C mc' then pseudo-graphics symbols are not displayed correctly. If MC is built with NCurses, everything is fine.

Well... I don't know how handle this situation... May be, like with NCurses (in src/tty/tty-ncurses.c:74 ). Or in other way, need to get 'lines' characters from utf-8 codepage into... 'LATIN1'? 'CP437'?

May be, we need to split this bugreport into two parts: colors(380) and lines(new ticket)?

[slavazanko]

Well, I'll create new ticket with bug of drawing lines.

For fixing color created branch 380_bw_colors_and_frames

review, please.

[slavazanko]

merge changeset:dec8a5d26e72f447d89c5ecd5d8f7dcb43f5367e

[andrew_b]

Replying to slavazanko:

2. Locale is KOI8-R. MC is built with S-Lang library. If run mc as 'LC_ALL=C mc' then pseudo-graphics symbols are not displayed correctly. If MC is built with NCurses, everything is fine.

Well... I don't know how handle this situation... May be, like with NCurses (in src/tty/tty-ncurses.c:74 ). Or in other way, need to get 'lines' characters from utf-8 codepage into... 'LATIN1'? 'CP437'?

May be, we need to split this bugreport into two parts: colors(380) and lines(new ticket)?

#1635

[andrew_b]

If invalid skin name is set via command line (or config file, or environment variable), then mc starts silently like -b -a mode. Two proposals, if required skin cannot be found:

1. Show error message "Cannot find skin"
2. Load the default.ini skin instead of set -a -c mode.

[slavazanko]

created branch 380_default_skin (parent: master)

initial changeset:e26511746ccb1e3519f928ed0ddc82a749ecd331

Review, please.

[slavazanko]

little minor fix: changeset:efb4fe362888200cd8eb17e40ddcb28144aede69

[slavazanko]

merge changeset:751bb696372da1a020deb5cc51165b349da2065e