Ticket #3794 (closed enhancement: fixed)
TypeScript syntax support
| Reported by: | mortiy | Owned by: | zaytsev |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.8.20 |
| Component: | mcedit | Version: | master |
| Keywords: | typescript | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
Syntax highlighting for TypeScript? language (https://www.typescriptlang.org)
Attachments
Change History
Changed 8 years ago by mortiy
- Attachment 0001-TypeScript-syntax-support.patch added
comment:1 Changed 8 years ago by zaytsev
Hi!
I can merge this, but I'm not really sure it's worth making a separate syntax for TypeScript. It's basically ES6 with interfaces and typing right? One benefit of adding TS stuff to JS syntax that I can think of is that it will automatically highlight flow annotations as well.
How do you feel about that?
Thanks!
comment:2 Changed 8 years ago by mortiy
Hi,
Yes, you are right, but besides typing there are also enums, access modifiers (private, protected, public), @decorators and several more keywords.
The point is that TypeScript? may go further and I am not sure if it is correct to fill js.syntax (which is more or less stable) with all that stuff.
For the same reason I think flow.js is out of js.syntax scope.
Do you agree? :)
comment:3 Changed 8 years ago by zaytsev
- Status changed from new to accepted
- Owner set to zaytsev
- Milestone changed from Future Releases to 4.8.20
comment:4 Changed 8 years ago by zaytsev
- Status changed from accepted to testing
- Votes for changeset set to committed-master
- Resolution set to fixed
- Branch state changed from no branch to merged
Committed to master: b1e16edd5ae31fd60f5dec9f96e14859ddfcae37 and 7e57d6e776131e6d7baac509bfb7d26643d1b279
comment:5 Changed 8 years ago by zaytsev
- Status changed from testing to closed
Ok, I agree about TypeScript?, but I still think that support for flow annotations should be added to js.syntax (if anyone will ever get to that). Thank you for the contribution!
TypeScript? syntax patch