Ticket #3748 (new enhancement)

Opened 2 years ago

Last modified 10 months ago

mksh as a subshell

Reported by: gloomyquazar Owned by:
Priority: minor Milestone: Future Releases
Component: mc-core Version: master
Keywords: subshell mksh Cc:
Blocked By: #3692 Blocking:
Branch state: no branch Votes for changeset:

Description

Hello.

On my desktop and notebook I use FreeBSD together with mksh, which I like for it's small size, robustness, security... Recently I got to know that MC supports only bash, (t)csh, zsh and something else as main shells, hence my mksh doesn't work as a subshell, I can't just switch with Ctrl+O and work there, so I had to postpone using MC for now. Is there a way to add mksh for supported shells? Without a subshell working in MC gets very unconvenient.

With regards,
Sergey P.

Attachments

mc-mksh-subshell.patch (2.8 KB) - added by gloomyquazar 22 months ago.
mc-mksh-subshell-v2.patch (2.8 KB) - added by gloomyquazar 22 months ago.

Change History

comment:1 follow-up: ↓ 2 Changed 2 years ago by gloomyquazar

It would be nice to also add support for general Bourne /bin/sh as a subshell.

comment:2 in reply to: ↑ 1 Changed 2 years ago by andrew_b

  • Blocked By 3692 added
  • Milestone changed from 4.8.19 to Future Releases

Replying to gloomyquazar:

It would be nice to also add support for general Bourne /bin/sh as a subshell.

#3658

comment:3 Changed 2 years ago by zaytsev

If mksh has an equivalent of precmd (which, I think, it does) and you can cook up a patch to support it that is not impossible.

comment:4 Changed 2 years ago by gloomyquazar

Maybe the function like this will do?

function precmd {

<put something here>

}

PS1="$(precmd) $PS1 "

comment:5 Changed 2 years ago by zaytsev

As I said, if you manage to provide a clean working patch, we might eventually get it in.

Changed 22 months ago by gloomyquazar

comment:6 Changed 22 months ago by gloomyquazar

Could you please check this patch? It works OK for me.

Changed 22 months ago by gloomyquazar

comment:7 Changed 10 months ago by woodsb02

Any progress on this?
The v2 patch looks simple enough.

Last edited 10 months ago by woodsb02 (previous) (diff)
Note: See TracTickets for help on using tickets.